From: jaypee@hotpop.com
To: linux-mips <linux-mips@linux-mips.org>
Subject: Re: Au1xxx ethernet race condition?
Date: Thu, 11 Aug 2005 09:28:05 +0000 [thread overview]
Message-ID: <1123752487l.30285l.8l@cavan> (raw)
In-Reply-To: <1123749337l.30285l.5l@cavan> (from jaypee@hotpop.com on Thu Aug 11 09:35:29 2005)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/08/05 09:35:29, jaypee@hotpop.com wrote:
>
> My theory as to why this occurs is that in au1000_tx there is a race
> condition.
>
> If a tx_done interrupt for the last tx buffer occurs between reading
> buff_stat (line 1905, au1000_eth.c) and calling netif_stop_queue then
> the queue won't get woken until the watchdog barks.
>
> I inserted a local_irq_save() at line 1903 and a local_irq_restore()
> at line 1915 and that seems to have fixed the problem. (Been running
> for half an hour with no netdev timeouts).
>
Oh you'll need to turn WARN_ON off or you'll get lots of
Badness in local_bh_enable warnings.
- --
mailto:jaypee@hotpop.com
http://www.jaypee.org.uk
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFC+xonZDxnKy3oOpYRApzaAKDVDqkfKA/gDXo9N6Kq2twilUVy2gCfWDRK
2qsrUN51BEFqtfXwLih7QhE=
=jbjw
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2005-08-11 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 8:35 Au1xxx ethernet race condition? jaypee
2005-08-11 9:05 ` Jerry
2005-08-11 9:25 ` jaypee
2005-08-11 9:28 ` jaypee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123752487l.30285l.8l@cavan \
--to=jaypee@hotpop.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox