Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Matej Kupljen <matej.kupljen@ultra.si>
To: Dan Malek <dan@embeddedalley.com>
Cc: Jordan Crouse <jordan.crouse@amd.com>,
	linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] Fix board type in db1x00
Date: Wed, 23 Nov 2005 07:31:37 +0100	[thread overview]
Message-ID: <1132727497.10318.8.camel@orionlinux.starfleet.com> (raw)
In-Reply-To: <6dabaec28e238ccc915f20f51ee28327@embeddedalley.com>

Hi

> > +	/* Set the platform # */
> > +#if	defined (CONFIG_MIPS_DB1550)
> > +	mips_machtype = MACH_DB1550;
> > +#elif	defined (CONFIG_MIPS_DB1500)
> > +	mips_machtype = MACH_DB1500;
> > +#elif	defined (CONFIG_MIPS_DB1100)
> > +	mips_machtype = MACH_DB1100;
> > +#else
> > +	mips_machtype = MACH_DB1000;
> > +#endif
> 
> Can't we just do something like
> 	#define MACH_ALCHEMY_TYPE  xxxxx
> 
> in the include files and not have this mess in the
> actual code?  Then, all we have to do here is:
> 
> 	mips_machtype = MACH_ALCHEMY_TYPE;

I prefer Dan's suggestion, if it counts.

And please, don't forget about DB1200 board also.
I already sent some minor patches, but they didn't
get in :(

BR,
Matej

  parent reply	other threads:[~2005-11-23  6:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-22 22:15 [PATCH] Fix board type in db1x00 Jordan Crouse
2005-11-22 22:31 ` Dan Malek
2005-11-23  0:15   ` Jordan Crouse
2005-11-23  0:24     ` Dan Malek
2005-11-23  1:18       ` Jordan Crouse
2005-11-23  6:31   ` Matej Kupljen [this message]
2005-11-23 14:39     ` [PATCH] " Dan Malek
2005-11-29 16:51   ` Ralf Baechle
2005-11-30  8:35     ` Matej Kupljen
2005-11-30 11:23       ` Ralf Baechle
2005-11-30 15:29       ` Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1132727497.10318.8.camel@orionlinux.starfleet.com \
    --to=matej.kupljen@ultra.si \
    --cc=dan@embeddedalley.com \
    --cc=jordan.crouse@amd.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox