Re: [PATCH] ALCHEMY: Alchemy Camera Interface (CIM) driver

[Matej Kupljen <matej.kupljen@ultra.si>]

Hi

> A driver for the AU1200 Camera Interface (CIM).  

Great news!

> I'm sending up right now, so comments and flames are definately
> welcome.

Wouldn't it be wise to support V4L2?
This way, many existing application could use AU1200s camera interface.


> +int __init
> +au1xxxcim_init(void)
> +{
> +	int retval, error;
> +	unsigned long page;
> +	CAMERA_RUNTIME *cam_init;
> +	CAMERA *cim_ptr;
> +
> +	cam_init = &cam_base;
> +	cam_init->cmos_camera = OrigCimArryPtr + prev_mode;
> +	cim_ptr = cam_init->cmos_camera;
> +
> +	/*Allocating memory for MMAP */
> +	mem_buf = (unsigned long *)Camera_mem_alloc(2 * MAX_FRAME_SIZE);
> +	if (mem_buf == NULL) {
> +		printk(KERN_ERR "MMAP unable to allocate memory \n");
> +	}

IMHO this is a waste of memory, because if the user is going to use
the camera in 320x240 mode and this allocates memory for the biggest
size. Wouldn't it be better to set some default configuration and
allocate memory for this? Later if the user changes the mode those
pages are freed and new (for requested size) are allocated.
Or even allocate memory AFTER the configuration has been set?

BR,
Matej