From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: anemo@mba.ocn.ne.jp
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: [PATCH 6/7] Make get_frame_info() more robust
Date: Thu, 3 Aug 2006 09:29:20 +0200 [thread overview]
Message-ID: <11545901628-git-send-email-vagabon.xyz@gmail.com> (raw)
In-Reply-To: <11545901611096-git-send-email-vagabon.xyz@gmail.com>
Now get_frame_info() wants to detect move sp instruction first. It
assumes that the save ra in the stack instruction can't happen
before allocating frame size space into the stack.
Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
---
arch/mips/kernel/process.c | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
index da332d7..309bfa4 100644
--- a/arch/mips/kernel/process.c
+++ b/arch/mips/kernel/process.c
@@ -321,17 +321,15 @@ static int get_frame_info(struct mips_fr
if (is_jal_jalr_jr_ins(ip))
break;
- if (is_sp_move_ins(ip)) {
- if (info->frame_size)
- continue;
- info->frame_size = - ip->i_format.simmediate;
+ if (!info->frame_size) {
+ if (is_sp_move_ins(ip))
+ info->frame_size = - ip->i_format.simmediate;
+ continue;
}
-
- if (is_ra_save_ins(ip)) {
- if (info->pc_offset != -1)
- continue;
+ if (info->pc_offset == -1 && is_ra_save_ins(ip)) {
info->pc_offset =
ip->i_format.simmediate / sizeof(long);
+ break;
}
}
if (info->frame_size && info->pc_offset >= 0) /* nested */
--
1.4.2.rc2
next prev parent reply other threads:[~2006-08-03 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 7:29 [PATCH 0/7] Improve prologue analysis code (take #2) Franck Bui-Huu
2006-08-03 7:29 ` [PATCH 1/7] Make get_frame_info() more readable Franck Bui-Huu
2006-08-03 7:29 ` [PATCH 2/7] Remove unused MODULE_RANGE macro Franck Bui-Huu
2006-08-03 7:29 ` [PATCH 3/7] Miscellaneous cleanup in prologue analysis code Franck Bui-Huu
2006-08-03 7:29 ` [PATCH 4/7] Make frame_info_init() more readable Franck Bui-Huu
2006-08-03 7:29 ` [PATCH 5/7] Simplify dump_stack() Franck Bui-Huu
2006-08-03 7:29 ` Franck Bui-Huu [this message]
2006-08-03 7:29 ` [PATCH 7/7] Improve unwind_stack() Franck Bui-Huu
2006-08-03 14:14 ` [PATCH 0/7] Improve prologue analysis code (take #2) Atsushi Nemoto
2006-08-03 15:58 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11545901628-git-send-email-vagabon.xyz@gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox