Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Frank Rowand <frank.rowand@am.sony.com>
To: linux-mips@linux-mips.org
Cc: frank.rowand@am.sony.com
Subject: [PATCH] RBTX4927: linux-2.6.24-rc4 hang on boot
Date: Tue, 11 Dec 2007 10:16:27 -0500	[thread overview]
Message-ID: <1197386187.5610.18.camel@localhost.localdomain> (raw)

In linux-2.6.24-rc4 the Toshiba RBTX4927 hangs on boot.

The cause is that plat_time_init() from arch/mips/tx4927/common/tx4927_setup.c
does not override the __weak plat_time_init() from arch/mips/kernel/time.c.
This is due to a compiler bug in gcc 4.1.1.  The bug is reported to not exist
in earlier versions of gcc, and to be fixed in 4.1.2.  The problem is that
the __weak plat_time_init() is empty and thus gets optimized out of
existence (thus the linker is never given the option to replace the
__weak function).

For more info on the gcc bug see

   http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781

The attached patch is one workaround.  Another possible workaround
would be to change the __weak plat_time_init() to be a non-empty
function.


Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>

---
 arch/mips/kernel/Makefile |    4 	4 +	0 -	0 !
 1 files changed, 4 insertions(+)

Index: linux-2.6.24-rc4/arch/mips/kernel/Makefile
===================================================================
--- linux-2.6.24-rc4.orig/arch/mips/kernel/Makefile
+++ linux-2.6.24-rc4/arch/mips/kernel/Makefile
@@ -83,6 +83,10 @@ obj-$(CONFIG_EARLY_PRINTK)	+= early_prin
 
 CFLAGS_cpu-bugs64.o	= $(shell if $(CC) $(KBUILD_CFLAGS) -Wa,-mdaddi -c -o /dev/null -xc /dev/null >/dev/null 2>&1; then echo "-DHAVE_AS_SET_DADDI"; fi)
 
+# workaround for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781,
+# which impacts plat_time_init() for tx4927, gcc 4.1.1
+CFLAGS_time.o			+= -fno-unit-at-a-time
+
 obj-$(CONFIG_HAVE_STD_PC_SERIAL_PORT)	+= 8250-platform.o
 
 EXTRA_CFLAGS += -Werror

             reply	other threads:[~2007-12-11 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11 15:16 Frank Rowand [this message]
2007-12-14  0:03 ` [PATCH] RBTX4927: linux-2.6.24-rc4 hang on boot Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197386187.5610.18.camel@localhost.localdomain \
    --to=frank.rowand@am.sony.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox