From: Kevin Hickey <khickey@rmicorp.com>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Alchemy: fix edge irq handling
Date: Mon, 26 Jan 2009 20:18:45 -0600 [thread overview]
Message-ID: <1233022725.14733.10.camel@kh-d820> (raw)
In-Reply-To: <20090121064856.GA27020@roarinelk.homelinux.net>
I am still concerned about this patch. Just last week we encountered
similar behavior that turned out to be a board design error. I had a
similar patch in that kernel that allowed me to run without error. Our
Windows CE developer, however, did not and ended up finding the board
bug. Fixing the board improved performance and system stability - had
we not been running CE we probably would not have found the issue until
much later and with greater effort.
Your example below is similar - debouncing the switch in hardware seems
a better solution (albeit likely an expensive one) than patching the
mainline kernel. And I reiterate: some devices send a lot of interrupts
by design; we should honor their requests, not mask them out.
=Kevin
On Wed, 2009-01-21 at 07:48 +0100, Manuel Lauss wrote:
> Hi Kevin,
>
> > Have you actually seen this happen (outside of inducing it manually)? I
> > have some concern that by doing this we may either miss interrupts on
> > devices that send a lot (by design) or miss a design bug in a system
> > because we are masking out some interrupts. I know that system
> > stability is important, but I don't like hiding problems.
>
> Yes, in a customer project. A simple pushbutton which connects a pulled-up
> gpio pin to ground. Push it, instant hang (handler called over and over
> again) when it is not debounced. With a single edge and a much lower
> edge-frequency it obviously works fine (see timer).
>
> (And, handle_edge_irq() _does_ call mask_ack() after all).
--
Kevin Hickey
Alchemy Solutions
RMI Corporation
khickey@rmicorp.com
P: 512.691.8044
next prev parent reply other threads:[~2009-01-27 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 10:03 [PATCH] Alchemy: fix edge irq handling Manuel Lauss
2009-01-21 0:47 ` Kevin Hickey
2009-01-21 6:48 ` Manuel Lauss
2009-01-27 2:18 ` Kevin Hickey [this message]
2009-01-27 6:20 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233022725.14733.10.camel@kh-d820 \
--to=khickey@rmicorp.com \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox