Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Zhang Le <r0bertz@gentoo.org>
Cc: Arnaud Patard <apatard@mandriva.com>,
	linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
	loongson-dev@googlegroups.com, zhangfx@lemote.com,
	yanh@lemote.com, Philippe Vachon <philippe@cowpig.ca>,
	Erwan Lerale <erwan@thiscow.com>
Subject: Re: [GIT repo] loongson: Merge and Clean up fuloong(2e), fuloong(2f) and yeeloong(2f) support
Date: Sat, 16 May 2009 02:00:03 +0800	[thread overview]
Message-ID: <1242410403.10164.122.camel@falcon> (raw)
In-Reply-To: <20090515170926.GE28012@adriano.hkcable.com.hk>

On Sat, 2009-05-16 at 01:09 +0800, Zhang Le wrote:
> On 18:38 Fri 15 May     , Wu Zhangjin wrote:
> > On Fri, 2009-05-15 at 10:25 +0200, Arnaud Patard wrote:
> > > - even if it should not affect the kernel, compiling with
> > >   -march=loongson2f even for 2e (you're matching on loongson2 so 2e and
> > >   2f) looks weird.
> > 
> > sorry, this is really a very obvious error, in 2e, -march=loongson2e
> > should be used.
> > 
> > to fix this problem, perhaps we can add two new kernel options:
> > 
> > config CPU_LOONGSON2E
> > 	bool
> > 
> > config CPU_LOONGSON2F
> > 	bool
> > 
> > and then use this solution:
> > 
> > config FULOONG2E
> > 	...
> > 	select CPU_LOONGSON2E
> > 	...
> > 
> > config YEELOONG2F
> > 	...
> > 	select CPU_LOONGSON2F
> > 	...
> > 
> > cflags-$(CONFIG_CPU_LOONGSON2E)  += -march=loongson2e -Wa,--trap
> > cflags-$(CONFIG_CPU_LOONGSON2F)  += -march=loongson2f -Wa,--trap
> > 
> > is this solution okay?
> 
> I have tried to solve this problem once. At that time, there is no loongson-dev
> list. So I send my patch to yanhua and zhang fuxin directly. It seems that they
> didn't forward that patch to you.
> 
> For the whole patch, please check attachment. It does not applicable on top of
> your work any more.
> 
> But here is how I deal with the CPU types:
> 
> @@ -951,14 +929,20 @@ choice
>        prompt "CPU type"
>        default CPU_R4X00
> 
> -config CPU_LOONGSON2
> -       bool "Loongson 2"
> -       depends on SYS_HAS_CPU_LOONGSON2
> -       select CPU_SUPPORTS_32BIT_KERNEL
> -       select CPU_SUPPORTS_64BIT_KERNEL
> -       select CPU_SUPPORTS_HIGHMEM
> +config CPU_LOONGSON2E
> +       bool "Loongson 2E"
> +       depends on SYS_HAS_CPU_LOONGSON2E
> +       select CPU_LOONGSON2
> +       help
> +         The Loongson 2E processor implements the MIPS III instruction set
> +         with many extensions.
> +
> +config CPU_LOONGSON2F
> +       bool "Loongson 2F"
> +       depends on SYS_HAS_CPU_LOONGSON2F
> +       select CPU_LOONGSON2
>         help
> -         The Loongson 2E/2F processor implements the MIPS III instruction set
> +         The Loongson 2F processor implements the MIPS III instruction set
>          with many extensions.
> 
>  config CPU_MIPS32_R1
> @@ -1171,7 +1155,16 @@ config CPU_SB1
> 
>  endchoice
> 
> -config SYS_HAS_CPU_LOONGSON2
> +config CPU_LOONGSON2
> +       bool
> +       select CPU_SUPPORTS_32BIT_KERNEL
> +       select CPU_SUPPORTS_64BIT_KERNEL
> +       select CPU_SUPPORTS_HIGHMEM
> +
> +config SYS_HAS_CPU_LOONGSON2E
> +       bool
> +
> +config SYS_HAS_CPU_LOONGSON2F
>         bool
> 
>  config SYS_HAS_CPU_MIPS32_R1
> 

applied it, thanks!

      reply	other threads:[~2009-05-15 18:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15  3:19 [GIT repo] loongson: Merge and Clean up fuloong(2e), fuloong(2f) and yeeloong(2f) support Wu Zhangjin
2009-05-15  8:25 ` Arnaud Patard
2009-05-15 10:38   ` Wu Zhangjin
2009-05-15 17:09     ` Zhang Le
2009-05-15 18:00       ` Wu Zhangjin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242410403.10164.122.camel@falcon \
    --to=wuzhangjin@gmail.com \
    --cc=apatard@mandriva.com \
    --cc=erwan@thiscow.com \
    --cc=linux-mips@linux-mips.org \
    --cc=loongson-dev@googlegroups.com \
    --cc=philippe@cowpig.ca \
    --cc=r0bertz@gentoo.org \
    --cc=ralf@linux-mips.org \
    --cc=yanh@lemote.com \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox