From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: apatard@mandriva.com, huhb@lemote.com, linux-mips@linux-mips.org,
ralf@linux-mips.org, yanh@lemote.com, philippe@cowpig.ca,
r0bertz@gentoo.org, zhangfx@lemote.com,
loongson-dev@googlegroups.com, der.herr@hofr.at,
liujl@lemote.com, erwan@thiscow.com
Subject: Re: [loongson-PATCH-v2 23/23] Hibernation Support in mips system
Date: Fri, 29 May 2009 01:06:39 +0800 [thread overview]
Message-ID: <1243530399.19464.1.camel@falcon> (raw)
In-Reply-To: <20090529.004452.242161110.anemo@mba.ocn.ne.jp>
On Fri, 2009-05-29 at 00:44 +0900, Atsushi Nemoto wrote:
> On Thu, 28 May 2009 02:52:19 +0800, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > diff --git a/arch/mips/power/hibernate.S b/arch/mips/power/hibernate.S
> > index 9dbe48e..1f06fd5 100644
> > --- a/arch/mips/power/hibernate.S
> > +++ b/arch/mips/power/hibernate.S
> ...
> > @@ -39,6 +47,16 @@ LEAF(swsusp_arch_resume)
> > bne t1, t3, 1b
> > PTR_L t0, PBE_NEXT(t0)
> > bnez t0, 0b
> > + /* flush caches to make sure context is in memory */
> > + PTR_LA t1, flush_cache_all
> > + PTR_L t0, 0(t1)
> > + jalr t0
> > + nop
>
> flush_cache_all is cache_noop on r4k. Maybe __flush_cache_all ?
>
> Also, you can write this like:
>
> PTR_L t0, flush_cache_all
> jalr t0
>
> The nop just after the jalr is not needed since or are in "reorder"
> mode here.
>
Applied.
Thanks!
Wu Zhangjin
next prev parent reply other threads:[~2009-05-28 17:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 18:59 [loongson-PATCH-v2 00/23] loongson-based machines support wuzhangjin
2009-05-26 19:01 ` [loongson-PATCH-v2 01/23] fix-warning: incompatible argument type of pci_fixup_irqs wuzhangjin
2009-05-26 19:02 ` [loongson-PATCH-v2 02/23] fix-warning: incompatible argument type of virt_to_phys wuzhangjin
2009-05-26 19:02 ` [loongson-PATCH-v2 03/23] change the naming methods wuzhangjin
2009-05-26 19:03 ` [loongson-PATCH-v2 04/23] remove reference to bonito64.h wuzhangjin
2009-05-26 19:04 ` [loongson-PATCH-v2 05/23] divide the files to the smallest logic unit wuzhangjin
2009-05-26 19:04 ` [loongson-PATCH-v2 06/23] replace tons of magic numbers by understandable symbols wuzhangjin
2009-05-27 9:27 ` Arnaud Patard
2009-05-27 15:26 ` Wu Zhangjin
2009-05-26 19:05 ` [loongson-PATCH-v2 07/23] clean up the early printk support for fuloong(2e) wuzhangjin
2009-05-26 19:05 ` [loongson-PATCH-v2 08/23] enable Real Time Clock Support " wuzhangjin
2009-05-26 19:05 ` [loongson-PATCH-v2 09/23] split the loongson-specific part out wuzhangjin
2009-05-26 19:06 ` [loongson-PATCH-v2 10/23] add basic loongson-2f support wuzhangjin
2009-05-26 19:06 ` [loongson-PATCH-v2 11/23] add basic fuloong(2f) support wuzhangjin
2009-05-26 19:07 ` [loongson-PATCH-v2 12/23] enable serial port support of loongson-based machines wuzhangjin
2009-05-26 19:07 ` [loongson-PATCH-v2 13/23] add basic yeeloong(2f) laptop support wuzhangjin
2009-05-26 19:07 ` [loongson-PATCH-v2 14/23] Add Siliconmotion 712 framebuffer driver wuzhangjin
2009-05-26 21:10 ` Geert Uytterhoeven
2009-05-26 21:10 ` Geert Uytterhoeven
2009-05-26 19:07 ` [loongson-PATCH-v2 15/23] define Loongson2F arch specific phys prot access wuzhangjin
2009-05-26 19:08 ` [loongson-PATCH-v2 16/23] Loongson2 specific OProfile driver wuzhangjin
2009-05-26 19:08 ` [loongson-PATCH-v2 17/23] flush posted write to irq wuzhangjin
2009-05-26 19:08 ` [loongson-PATCH-v2 18/23] CS5536 MFGPT as system clock source support wuzhangjin
2009-05-26 19:08 ` [loongson-PATCH-v2 19/23] Loongson2F cpufreq support wuzhangjin
2009-05-27 9:46 ` Arnaud Patard
2009-05-27 17:37 ` Wu Zhangjin
2009-05-27 17:37 ` Wu Zhangjin
2009-05-27 19:18 ` Arnaud Patard
2009-05-27 19:18 ` Arnaud Patard
2009-05-27 10:01 ` Manuel Lauss
2009-05-27 18:28 ` Wu Zhangjin
2009-05-26 19:09 ` [loongson-PATCH-v2 20/23] add gcc 4.4 support for MIPS and loongson wuzhangjin
2009-05-27 9:22 ` Arnaud Patard
2009-05-27 14:23 ` Wu Zhangjin
2009-05-26 19:09 ` [loongson-PATCH-v2 21/23] add default kernel config file for loongson-based machines wuzhangjin
2009-05-26 19:09 ` [loongson-PATCH-v2 22/23] add a default kernel configration for yeeloong-7inch laptop wuzhangjin
2009-05-26 19:10 ` [loongson-PATCH-v2 23/23] Hibernation Support in mips system wuzhangjin
2009-05-27 9:51 ` Arnaud Patard
2009-05-27 18:52 ` Wu Zhangjin
2009-05-28 15:44 ` Atsushi Nemoto
2009-05-28 17:06 ` Wu Zhangjin [this message]
2009-05-28 15:32 ` Atsushi Nemoto
2009-05-28 17:10 ` Wu Zhangjin
2009-05-29 16:12 ` Atsushi Nemoto
2009-05-29 19:12 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243530399.19464.1.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=apatard@mandriva.com \
--cc=der.herr@hofr.at \
--cc=erwan@thiscow.com \
--cc=huhb@lemote.com \
--cc=linux-mips@linux-mips.org \
--cc=liujl@lemote.com \
--cc=loongson-dev@googlegroups.com \
--cc=philippe@cowpig.ca \
--cc=r0bertz@gentoo.org \
--cc=ralf@linux-mips.org \
--cc=yanh@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox