From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 15 Jun 2009 20:49:45 +0200 (CEST) Received: from mail-ew0-f221.google.com ([209.85.219.221]:34054 "EHLO mail-ew0-f221.google.com" rhost-flags-OK-OK-OK-OK) by ftp.linux-mips.org with ESMTP id S1492668AbZFOStj (ORCPT ); Mon, 15 Jun 2009 20:49:39 +0200 Received: by ewy21 with SMTP id 21so2684109ewy.0 for ; Mon, 15 Jun 2009 11:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=n57I1P28JstXL0lgUO+A26FkDlRuyESv5LJou/akgao=; b=qewarFwabRDwpJpsF6zrbGTn8C+dgSZg//SZihbSp14cXyMXFdBbqunvfj8ZLPsPWS O0q0jSYbyXrdMSLVFsoSnZEpvaEaXhA9NYwhK1J+AdRIqyhNoPr1uMfG/kxlwa4dIWLd BbEu1ZaoJON/UVRm+Mmgi7Fnpqd3eC1/LHbj4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=Ocs0P99hOJ/Nlw/VsiP0393HVJ0+OBkqpYqGRVs2UfV6lPBWTRz+9rADqxjSVGyoDp vlysmuKEiEIIuk7DWqssU2zXoH9tLCY0dpOpxgy1vNUrxJxxV7kxezcqq3BuU9n7v/dz Rg9Jh8W7rH5JvLYm9+SMdeyN3CeH+ureuBFlQ= Received: by 10.210.111.17 with SMTP id j17mr5989339ebc.83.1245091721777; Mon, 15 Jun 2009 11:48:41 -0700 (PDT) Received: from ?192.168.1.100? ([219.246.59.144]) by mx.google.com with ESMTPS id 5sm131092eyf.28.2009.06.15.11.48.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 15 Jun 2009 11:48:40 -0700 (PDT) Subject: Re: [PATCH v3] filter local function prefixed by $L From: Wu Zhangjin Reply-To: wuzhangjin@gmail.com To: Steven Rostedt Cc: David Daney , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Wang Liming , Ralf Baechle , Thomas Gleixner , Nicholas Mc Guire , Ingo Molnar In-Reply-To: References: <4A366FF7.2010206@caviumnetworks.com> Content-Type: text/plain Organization: DSLab, Lanzhou University, China Date: Tue, 16 Jun 2009 02:48:30 +0800 Message-Id: <1245091710.6381.74.camel@falcon> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 23425 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: wuzhangjin@gmail.com Precedence: bulk X-list: linux-mips On Mon, 2009-06-15 at 12:30 -0400, Steven Rostedt wrote: > On Mon, 15 Jun 2009, David Daney wrote: > > > Wu Zhangjin wrote: > > > From: Wu Zhangjin > > > > > > this patch fixed the warning as following: > > > > > > mipsel-linux-gnu-objcopy: 'fs/proc/.tmp_gl_devices.o': No such file > > > mipsel-linux-gnu-ld: fs/proc/.tmp_gl_devices.o: No such file: No such > > > file or directory > > > rm: cannot remove `fs/proc/.tmp_gl_devices.o': No such file or directory > > > rm: cannot remove `fs/proc/.tmp_mx_devices.o': No such file or directory > > > > > > the real reason of above warning is that the $Lxx local functions will > > > be treated as global symbols, so, should be filtered. > > > > > > Signed-off-by: Wu Zhangjin > > > --- > > > scripts/recordmcount.pl | 4 ++++ > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > > > index 533d3bf..542cb04 100755 > > > --- a/scripts/recordmcount.pl > > > +++ b/scripts/recordmcount.pl > > > @@ -343,6 +343,10 @@ sub update_funcs > > > if (!$use_locals) { > > > return; > > > } > > > + # filter $LXXX tags > > > + if ("$ref_func" =~ m/\$L/) { > > > + return; > > > + } > > > > Certainly this is true for mips. I doubt it is for all architectures targed > > by Linux. > have tried to use function_regex instead, but for I'm poor in playing with regular expression of perl. at last, i use something easier like above. and I _guess_ this problem maybe exist in some other platforms, so just put it there. > Yes, that should probably go into a mips only change. Unless you can > reproduce it on all other archs, or at least x86. > > You could also do this in the function_regex variable. > > "^([0-9a-fA-F]+)\\s+<(.|[^\$]L.*?|\$[^L].*?|[^\$][^L].*?)>:" > works well, and this seems mips64-specific, so, I moved this specific function_regex to "if ($bits == 64) { ... }". > There may even be a better way, but I'm not in the mood to look it up ;-) seems not that easy to understand :-) -- Wu Zhangjin