From: Artem Bityutskiy <dedekind@infradead.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: Martin Michlmayr <tbm@cyrius.com>,
linux-mips@linux-mips.org, dwmw2@infradead.org,
Yoichi Yuasa <yuasa@linux-mips.org>
Subject: Re: mtd related Cobalt build failure with current git
Date: Fri, 10 Jul 2009 09:03:05 +0300 [thread overview]
Message-ID: <1247205785.20721.359.camel@localhost.localdomain> (raw)
In-Reply-To: <200907051310.02673.florian@openwrt.org>
On Sun, 2009-07-05 at 13:10 +0200, Florian Fainelli wrote:
> Hi Martin,
>
> Le Saturday 04 July 2009 23:37:41 Martin Michlmayr, vous avez écrit :
> > I get the following Cobalt build failure with current git:
> >
> > CC arch/mips/cobalt/mtd.o
> > cc1: warnings being treated as errors
> > In file included from arch/mips/cobalt/mtd.c:22:
> > include/linux/mtd/partitions.h:50: warning: ‘struct mtd_info’ declared
> > inside parameter list include/linux/mtd/partitions.h:50: warning: its scope
> > is only this definition or declaration, which is probably not what you want
> > include/linux/mtd/partitions.h:51: warning: ‘struct mtd_info’ declared
> > inside parameter list include/linux/mtd/partitions.h:61: warning: ‘struct
> > mtd_info’ declared inside parameter list include/linux/mtd/partitions.h:67:
> > warning: ‘struct mtd_info’ declared inside parameter list make[1]: ***
> > [arch/mips/cobalt/mtd.o] Error 1
> > make: *** [arch/mips/cobalt] Error 2
> >
> > Does anyone know if there's a fix for this already?
>
> I also had that problem and did the following fix, which still applies to
> the mtd-2.6 tree, master branch.
> --
> From: Florian Fainelli <florian@openwrt.org>
> Subject: [PATCH] Fix arch/mips/cobalt/mtd.c build failure
>
> This patch fixes a warning in include/linux/mtd/partitions which
> results in the following build failure on MIPS:
> CC arch/mips/cobalt/mtd.o
> cc1: warnings being treated as errors
> In file included from arch/mips/cobalt/mtd.c:22:
> include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list
> make[1]: *** [arch/mips/cobalt/mtd.o] Error 1
> make: *** [arch/mips/cobalt] Error 2
>
> Reported-by: Martin Michlmayr <tbm@cyrius.com>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h
> index af6dcb9..c8eaf44 100644
> --- a/include/linux/mtd/partitions.h
> +++ b/include/linux/mtd/partitions.h
> @@ -10,7 +10,7 @@
> #define MTD_PARTITIONS_H
>
> #include <linux/types.h>
> -
> +#include <linux/mtd/mtd.h>
Can you instead add
a struct mtd_info forward-declaration?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
prev parent reply other threads:[~2009-07-10 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 21:37 mtd related Cobalt build failure with current git Martin Michlmayr
2009-07-05 11:10 ` Florian Fainelli
2009-07-06 15:38 ` Martin Michlmayr
2009-07-10 6:03 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247205785.20721.359.camel@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=dwmw2@infradead.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=tbm@cyrius.com \
--cc=yuasa@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox