Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Arnaud Patard <apatard@mandriva.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, rtc-linux@googlegroups.com
Subject: Re: [PATCH 2/2] [loongson] fuloong: add RTC_LIB Support
Date: Thu, 05 Nov 2009 08:37:23 +0800	[thread overview]
Message-ID: <1257381443.16033.6.camel@falcon.domain.org> (raw)
In-Reply-To: <m31vketgyw.fsf@anduin.mandriva.com>

Hi,

On Wed, 2009-11-04 at 17:03 +0100, Arnaud Patard wrote:
> Wu Zhangjin <wuzhangjin@gmail.com> writes:
> Hi,
> 
> > + *  Registration of Cobalt RTC platform device.
> 
> Of Cobalt platform device ? I thought we were on loongson :)
> 

Ooh, I just copied the header ;) will remove it later.

> > + *
> > + *  Copyright (C) 2007  Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> > + *  Copyright (C) 2009  Wu Zhangjin <wuzj@lemote.com>
> > + *
> > + *  This program is free software; you can redistribute it and/or modify
> > + *  it under the terms of the GNU General Public License as published by
> > + *  the Free Software Foundation; either version 2 of the License, or
> > + *  (at your option) any later version.
> > + */
> > +
> > +#include <linux/init.h>
> > +#include <linux/ioport.h>
> > +#include <linux/mc146818rtc.h>
> > +#include <linux/platform_device.h>
> > +
> > +static struct resource rtc_cmos_resource[] = {
> > +	{
> > +		.start	= RTC_PORT(0),
> > +		.end	= RTC_PORT(1),
> > +		.flags	= IORESOURCE_IO,
> > +	},
> > +	{
> > +		.start	= RTC_IRQ,
> > +		.end	= RTC_IRQ,
> > +		.flags	= IORESOURCE_IRQ,
> > +	},
> > +};
> > +
> > +static struct platform_device rtc_cmos_device = {
> > +	.name		= "rtc_cmos",
> > +	.id		= -1,
> > +	.num_resources	= ARRAY_SIZE(rtc_cmos_resource),
> > +	.resource	= rtc_cmos_resource
> > +};
> > +
> > +static __init int rtc_cmos_init(void)
> > +{
> > +	platform_device_register(&rtc_cmos_device);
> > +
> > +	return 0;
> 
> what about return platform_device_register(&rtc_cmos_device); ?
> 
> 

Okay, later.

Regards,
	Wu Zhangjin

      reply	other threads:[~2009-11-05  0:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 15:49 [PATCH 2/2] [loongson] fuloong: add RTC_LIB Support Wu Zhangjin
2009-11-04 16:03 ` Arnaud Patard
2009-11-05  0:37   ` Wu Zhangjin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257381443.16033.6.camel@falcon.domain.org \
    --to=wuzhangjin@gmail.com \
    --cc=apatard@mandriva.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox