From: Wu Zhangjin <wuzhangjin@gmail.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
zhangfx@lemote.com, zhouqg@gmail.com,
Ralf Baechle <ralf@linux-mips.org>,
rostedt@goodmis.org, Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Nicholas Mc Guire <der.herr@hofr.at>,
Richard Sandiford <rdsandiford@googlemail.com>,
Patrik Kluba <kpajko79@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH v7 17/17] tracing: make function graph tracer work with -mmcount-ra-address
Date: Tue, 10 Nov 2009 10:42:57 +0800 [thread overview]
Message-ID: <1257820977.2822.32.camel@falcon.domain.org> (raw)
In-Reply-To: <4AF898E9.3050506@caviumnetworks.com>
Hi,
On Mon, 2009-11-09 at 14:34 -0800, David Daney wrote:
> Wu Zhangjin wrote:
> [...]
> > + cflags-y += $(call cc-option, -mmcount-ra-address)
> [...]
> > +#if (__GNUC__ <= 4 && __GNUC_MINOR__ < 5)
>
>
>
> Sprinkling the code with these #if clauses is ugly and prone to breakage
> I think.
>
> The Makefile part is testing for the same feature.
>
> We do a very similar thing with -msym32, and KBUILD_SYM32. Perhaps you
> could rework this patch in a similar manner and test for
> KBUILD_MCOUNT_RA_ADDRESS instead of the '(__GNUC__ <= 4 &&
> __GNUC_MINOR__ < 5)'
>
This is really ugly ;)
KBUILD_MCOUNT_RA_ADDRESS is a wonderful idea, thanks!
Regards,
Wu Zhangjin
prev parent reply other threads:[~2009-11-10 2:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 15:29 [PATCH v7 00/17] ftrace for MIPS Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 01/17] tracing: convert trace_clock_local() as weak function Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 02/17] tracing: add mips_timecounter_read() for MIPS Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 03/17] tracing: add MIPS specific trace_clock_local() Wu Zhangjin
2009-11-10 17:48 ` David Daney
2009-11-11 2:47 ` Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 04/17] tracing: add static function tracer support for MIPS Wu Zhangjin
2009-11-10 0:26 ` David Daney
2009-11-10 1:00 ` Wu Zhangjin
2009-11-10 16:43 ` David Daney
2009-11-11 2:42 ` Wu Zhangjin
2009-11-11 3:13 ` Ralf Baechle
2009-11-11 13:30 ` Maciej W. Rozycki
2009-11-12 21:16 ` Ralf Baechle
2009-11-11 14:13 ` Maciej W. Rozycki
2009-11-13 16:50 ` Ralf Baechle
2009-11-11 13:15 ` Maciej W. Rozycki
2009-11-11 13:51 ` Wu Zhangjin
2009-11-11 14:18 ` Maciej W. Rozycki
2009-11-11 14:27 ` Wu Zhangjin
2009-11-12 11:06 ` Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 05/17] tracing: enable HAVE_FUNCTION_TRACE_MCOUNT_TEST " Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 06/17] tracing: add an endian argument to scripts/recordmcount.pl Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 07/17] tracing: add dynamic function tracer support for MIPS Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 08/17] tracing: add IRQENTRY_EXIT section " Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 09/17] tracing: define a new __time_notrace annotation flag Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 10/17] tracing: not trace the timecounter_read* in kernel/time/clocksource.c Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 11/17] tracing: not trace mips_timecounter_read() for MIPS Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 12/17] tracing: add function graph tracer support " Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 13/17] tracing: add dynamic function graph tracer " Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 14/17] tracing: make ftrace for MIPS work without -fno-omit-frame-pointer Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 15/17] tracing: make ftrace for MIPS more robust Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 16/17] tracing: reserve $12(t0) for mcount-ra-address of gcc 4.5 Wu Zhangjin
2009-11-09 15:31 ` [PATCH v7 17/17] tracing: make function graph tracer work with -mmcount-ra-address Wu Zhangjin
2009-11-09 22:34 ` David Daney
2009-11-10 2:42 ` Wu Zhangjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257820977.2822.32.camel@falcon.domain.org \
--to=wuzhangjin@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=der.herr@hofr.at \
--cc=fweisbec@gmail.com \
--cc=kpajko79@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=ralf@linux-mips.org \
--cc=rdsandiford@googlemail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhangfx@lemote.com \
--cc=zhouqg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).