From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, cpufreq@vger.kernel.org,
Dave Jones <davej@redhat.com>,
yanh@lemote.com, huhb@lemote.com
Subject: Re: [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support
Date: Thu, 12 Nov 2009 09:47:45 +0800 [thread overview]
Message-ID: <1257990465.3113.38.camel@falcon.domain.org> (raw)
In-Reply-To: <20091111182113.GB2690@comet.dominikbrodowski.net>
Hi,
On Wed, 2009-11-11 at 19:21 +0100, Dominik Brodowski wrote:
[...]
> > + result = cpufreq_register_driver(&loongson2_cpufreq_driver);
> > +
> > + if (!result && !nowait) {
> > + saved_cpu_wait = cpu_wait;
> > + cpu_wait = loongson2_cpu_wait;
> > + }
> > +
> > + cpufreq_register_notifier(&loongson2_cpufreq_notifier_block,
> > + CPUFREQ_TRANSITION_NOTIFIER);
>
> IMO you should register the transition notifier before register_driver(),
> else there's a small window where a change may be initiate which is not
> notified...
>
Will adjust them later, thanks!
Regards,
Wu Zhangjin
prev parent reply other threads:[~2009-11-12 1:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 7:09 [PATCH -queue 0/3] add CPUFreq support for loongson2f Wu Zhangjin
2009-11-11 7:09 ` [PATCH -queue 1/3] [loongson] lemote-2f: add cs5536 MFGPT timer support Wu Zhangjin
2009-11-11 13:41 ` Wu Zhangjin
2009-11-12 20:17 ` Ralf Baechle
2009-11-13 6:16 ` Wu Zhangjin
2009-11-11 7:09 ` [PATCH -queue 2/3] MIPS: add basic options for CPUFreq support Wu Zhangjin
2009-11-11 7:09 ` [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support Wu Zhangjin
2009-11-11 18:21 ` Dominik Brodowski
2009-11-12 1:47 ` Wu Zhangjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257990465.3113.38.camel@falcon.domain.org \
--to=wuzhangjin@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=huhb@lemote.com \
--cc=linux-mips@linux-mips.org \
--cc=linux@dominikbrodowski.net \
--cc=ralf@linux-mips.org \
--cc=yanh@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).