From mboxrd@z Thu Jan  1 00:00:00 1970
Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 16 Nov 2009 16:10:56 +0100 (CET)
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:59683 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK)
	by ftp.linux-mips.org with ESMTP id S1493402AbZKPPKs (ORCPT
	<rfc822;linux-mips@linux-mips.org>); Mon, 16 Nov 2009 16:10:48 +0100
Received: from [192.168.23.10] (really [74.67.89.75])
          by hrndva-omta03.mail.rr.com with ESMTP
          id <20091116151041853.DVRB12367@hrndva-omta03.mail.rr.com>;
          Mon, 16 Nov 2009 15:10:41 +0000
Subject: Re: [PATCH v8 06/16] tracing: add an endian argument to
 scripts/recordmcount.pl
From:	Steven Rostedt <rostedt@goodmis.org>
Reply-To: rostedt@goodmis.org
To:	wuzhangjin@gmail.com
Cc:	Thomas Gleixner <tglx@linutronix.de>,
	Ralf Baechle <ralf@linux-mips.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Nicholas Mc Guire <der.herr@hofr.at>,
	David Daney <ddaney@caviumnetworks.com>,
	Richard Sandiford <rdsandiford@googlemail.com>,
	Patrik Kluba <kpajko79@gmail.com>,
	Michal Simek <monstr@monstr.eu>,
	"Maciej W . Rozycki" <macro@linux-mips.org>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	zhangfx@lemote.com, zhouqg@gmail.com
In-Reply-To: <1258381775.15821.1.camel@falcon.domain.org>
References: <9dc81a7a9e5a292cccdf465c533a2b08d19d6021.1258177321.git.wuzhangjin@gmail.com>
	 <b99c08397d9ff92ac5a72bda9131df41b702fc71.1258177321.git.wuzhangjin@gmail.com>
	 <8f579e2cece16cd22358a4ec143ef6a8c462639b.1258177321.git.wuzhangjin@gmail.com>
	 <ea337742d3ca7eec2825416041a6d4fa917d5cc4.1258177321.git.wuzhangjin@gmail.com>
	 <7c7568247ad6cc109ec20387cfc3ca258d1d430f.1258177321.git.wuzhangjin@gmail.com>
	 <3fcaffcfb3c8c8cd3015151ed5b7480ccaecde0f.1258177321.git.wuzhangjin@gmail.com>
	 <alpine.LFD.2.00.0911161520080.24119@localhost.localdomain>
	 <1258381775.15821.1.camel@falcon.domain.org>
Content-Type: text/plain
Organization: Kihon Technologies Inc.
Date:	Mon, 16 Nov 2009 10:10:40 -0500
Message-Id: <1258384240.22249.453.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.3 
Content-Transfer-Encoding: 7bit
Return-Path: <rostedt@goodmis.org>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 24916
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: rostedt@goodmis.org
Precedence: bulk
X-list: linux-mips

On Mon, 2009-11-16 at 22:29 +0800, Wu Zhangjin wrote:
> On Mon, 2009-11-16 at 15:21 +0100, Thomas Gleixner wrote:
> > On Sat, 14 Nov 2009, Wu Zhangjin wrote:
> > 
> > > From: Wu Zhangjin <wuzhangjin@gmail.com>
> > > 
> > > MIPS and some other architectures need this argument to handle
> > > big/little endian respectively.
> > 
> > Hmm, the patch adds the endian argument to the command line, but does
> > nothing else with it. Is there something missing from the patch or is
> > it just a left over from earlier iterations ?
> > 
> 
> It is used in: 
> 
> [PATCH v8 07/16] tracing: add dynamic function tracer support for MIPS
> 
> Steven told me to split it out ;)

Heh, IIRC I think I meant to split out the recordmcount.pl code first.
But this is fine too ;-)

-- Steve