Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
	Wu Zhangjin <wuzhangjin@gmail.com>
Subject: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
Date: Tue, 24 Nov 2009 17:33:50 +0800	[thread overview]
Message-ID: <1259055230-15818-1-git-send-email-wuzhangjin@gmail.com> (raw)

From: Wu Zhangjin <wuzhangjin@gmail.com>

In the old version, if the platform select SYS_HAS_EARLY_PRINTK and
users not select DEBUG_KERNEL, there is no interface for user to enable
or disable the EARLY_PRINTK option, it will be enabled all the time.
this will waste a little bit of memory and slow down the booting of
kernel but the users never know it.

This patch will only enable that option when the DEBUG_KERNEL is
enabled.

Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
 arch/mips/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index b342197..d2446d5 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -824,8 +824,8 @@ config DMA_NEED_PCI_MAP_STATE
 	bool
 
 config EARLY_PRINTK
-	bool "Early printk" if EMBEDDED && DEBUG_KERNEL
-	depends on SYS_HAS_EARLY_PRINTK
+	bool "Early printk" if EMBEDDED
+	depends on SYS_HAS_EARLY_PRINTK && DEBUG_KERNEL
 	default y
 	help
 	  This option enables special console drivers which allow the kernel
-- 
1.6.2.1

             reply	other threads:[~2009-11-24  9:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24  9:33 Wu Zhangjin [this message]
2009-11-24 16:24 ` [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency Manuel Lauss
2009-11-24 16:30   ` Ralf Baechle
2009-11-25 14:42     ` Kevin Hickey
2009-11-25 16:15       ` Wu Zhangjin
2009-11-25 16:19         ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259055230-15818-1-git-send-email-wuzhangjin@gmail.com \
    --to=wuzhangjin@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox