From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
linux-mips@linux-mips.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH v5] MIPS: Add a high resolution sched_clock() via cnt32_to_63().
Date: Fri, 27 Nov 2009 11:05:34 +0800 [thread overview]
Message-ID: <1259291134.3197.86.camel@falcon.domain.org> (raw)
In-Reply-To: <4B0EC5CB.5060701@ru.mvista.com>
On Thu, 2009-11-26 at 21:15 +0300, Sergei Shtylyov wrote:
> Hello, I wrote:
>
> >> From: Wu Zhangjin <wuzhangjin@gmail.com>
>
> >> (This v5 revision incorporates with the feedbacks from Ingo.)
>
> >> This patch adds a cnt32_to_63() and MIPS c0 count based sched_clock(),
> >> which provides high resolution. and also, one new kernel option
> >> (HR_SCHED_CLOCK) is added to enable/disable this sched_clock().
>
> >> Without it, the Ftrace for MIPS will give useless timestamp information.
>
> >> Because cnt32_to_63() needs to be called at least once per half period
> >> to work properly, Differ from the old version, this v2 revision set up a
> >> kernel timer to ensure the requirement of some MIPSs which have short c0
> >> count period.
>
> >> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
>
> >> diff --git a/arch/mips/kernel/csrc-r4k-hres.c
> >> b/arch/mips/kernel/csrc-r4k-hres.c
> >> new file mode 100644
> >> index 0000000..2fe8be7
> >> --- /dev/null
> >> +++ b/arch/mips/kernel/csrc-r4k-hres.c
> >
> >
> > I don't think this is really good name for this file (one might think
> > that this is another implementation of clocksource instead of some
> > sched_clock() code tied to this particular clocksource), and I don't
>
> Seriously, if this file have to live a life of its own, name it like
> sched-r4k.c but not the way you named it -- this is not another clocksource
> module...
>
Hello, Sergei Shtylyov, I will use hres_sched_clock.c instead of
sched-r4k.c, is it okay?
Hi, Ralf, which one will you apply? If hres_sched_clock.c is okay, I
will resend it asap.
Thakns & Regards,
Wu Zhangjin
next prev parent reply other threads:[~2009-11-27 3:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 10:28 [PATCH v5] MIPS: Add a high resolution sched_clock() via cnt32_to_63() Wu Zhangjin
2009-11-23 10:36 ` Ingo Molnar
2009-11-23 13:11 ` Sergei Shtylyov
2009-11-23 17:46 ` Ingo Molnar
2009-11-26 18:15 ` Sergei Shtylyov
2009-11-27 1:07 ` Wu Zhangjin
2009-11-27 3:05 ` Wu Zhangjin [this message]
2009-11-27 4:45 ` David Daney
2009-11-27 8:35 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259291134.3197.86.camel@falcon.domain.org \
--to=wuzhangjin@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).