From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: David Daney <david.s.daney@gmail.com>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-mips@linux-mips.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH v5] MIPS: Add a high resolution sched_clock() via cnt32_to_63().
Date: Fri, 27 Nov 2009 16:35:02 +0800 [thread overview]
Message-ID: <1259310902.3197.97.camel@falcon.domain.org> (raw)
In-Reply-To: <4B0F595C.5000204@gmail.com>
Hi, Ralf
This patch is not applicable, please ignore it!
Thanks!
Wu Zhangjin
On Thu, 2009-11-26 at 20:45 -0800, David Daney wrote:
> On 11/26/2009 07:05 PM, Wu Zhangjin wrote:
> > On Thu, 2009-11-26 at 21:15 +0300, Sergei Shtylyov wrote:
> [...]
> >>>
> >>> I don't think this is really good name for this file (one might think
> >>> that this is another implementation of clocksource instead of some
> >>> sched_clock() code tied to this particular clocksource), and I don't
> >>>
> >> Seriously, if this file have to live a life of its own, name it like
> >> sched-r4k.c but not the way you named it -- this is not another clocksource
> >> module...
> >>
> >>
> > Hello, Sergei Shtylyov, I will use hres_sched_clock.c instead of
> > sched-r4k.c, is it okay?
> >
> > Hi, Ralf, which one will you apply? If hres_sched_clock.c is okay, I
> > will resend it asap.
> >
>
> Like Sergei, I think putting this in a seperate file is a bad idea.
> This sched_clock is just a slightly different view of the csrc-r4k.c
> put it in there.
>
> Octeon has its own clock source (cavium-octeon/scrc-octeon.c) and
> doesn't use csrc-r4k, so if you put it in a seperate file, there will
> have to be makefile hackery to keep this thing out of an octeon kernel.
>
> When and if you add this to csrc-r4k, I will submit the patch (already
> written) that adds a high resolution sched_clock() to csrc-octeon.c.
>
> Thanks,
> David Daney
>
>
>
>
prev parent reply other threads:[~2009-11-27 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 10:28 [PATCH v5] MIPS: Add a high resolution sched_clock() via cnt32_to_63() Wu Zhangjin
2009-11-23 10:36 ` Ingo Molnar
2009-11-23 13:11 ` Sergei Shtylyov
2009-11-23 17:46 ` Ingo Molnar
2009-11-26 18:15 ` Sergei Shtylyov
2009-11-27 1:07 ` Wu Zhangjin
2009-11-27 3:05 ` Wu Zhangjin
2009-11-27 4:45 ` David Daney
2009-11-27 8:35 ` Wu Zhangjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259310902.3197.97.camel@falcon.domain.org \
--to=wuzhangjin@gmail.com \
--cc=david.s.daney@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).