From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support
Date: Wed, 27 Jan 2010 00:01:19 +0800 [thread overview]
Message-ID: <1264521679.24895.30.camel@falcon> (raw)
In-Reply-To: <1264521494.24895.28.camel@falcon>
On Tue, 2010-01-26 at 23:58 +0800, Wu Zhangjin wrote:
> On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote:
> > Hi,
> >
> > On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > > Changes from v1 (feedbacks from Ralf):
> > >
> > > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL
> > >
> > > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the
> >
> > Not every chip has a standard 16550, unfortunately. I liked your
> > first iteration better:
> > DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another
> > (invisible)
> > config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550
> > for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported
> > chips).
> >
>
> Yes, It will be not convenient for a new serial port debugging support
> with the current modification, for example, if you add UARTXXXX, we need
> to select it for the new board and also add it under the "depends" of
> DEBUG_ZBOOT. how about this?
>
> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
> index 5e556f7..6fccbf0 100644
> --- a/arch/mips/Kconfig.debug
> +++ b/arch/mips/Kconfig.debug
> @@ -104,7 +104,7 @@ config RUNTIME_DEBUG
>
> config DEBUG_ZBOOT
> bool "Enable compressed kernel support debugging"
> - depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT_UART16550
> + depends on DEBUG_KERNEL
>
oh, no, this dependency is also needed: SYS_SUPPORTS_ZBOOT, so, it
should be:
depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT
> and we keep the old:
>
> ifdef CONFIG_DEBUG_ZBOOT
> obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> endif
>
> If a new serial port is needed, we just need to add the following lines
> to arch/mips/Kconfig
>
> config SYS_SUPPORTS_ZBOOT_UARTXXX
> bool
> select SYS_SUPPORTS_ZBOOT
>
> config MACH_XXXX
> [...]
> select SYS_SUPPORTS_ZBOOT_UARTXXX
> [...]
>
> and in arch/mips/boot/compressed/Makfefile
>
> ifdef CONFIG_DEBUG_ZBOOT
> obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UARTXXX) += $(obj)/uart-xxx.o
> endif
>
> and also a new arch/mips/boot/compressed/uar-xxx.c is needed.
>
> If this is okay, I will send a new revision asap.
>
> Regards,
> Wu Zhangjin
WARNING: multiple messages have this Message-ID (diff)
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support
Date: Wed, 27 Jan 2010 00:01:19 +0800 [thread overview]
Message-ID: <1264521679.24895.30.camel@falcon> (raw)
Message-ID: <20100126160119.EClooXhvk_91VB5bLto1ZP4fGKPx_ISh5u0-zLwEuUo@z> (raw)
In-Reply-To: <1264521494.24895.28.camel@falcon>
On Tue, 2010-01-26 at 23:58 +0800, Wu Zhangjin wrote:
> On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote:
> > Hi,
> >
> > On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > > Changes from v1 (feedbacks from Ralf):
> > >
> > > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL
> > >
> > > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the
> >
> > Not every chip has a standard 16550, unfortunately. I liked your
> > first iteration better:
> > DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another
> > (invisible)
> > config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550
> > for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported
> > chips).
> >
>
> Yes, It will be not convenient for a new serial port debugging support
> with the current modification, for example, if you add UARTXXXX, we need
> to select it for the new board and also add it under the "depends" of
> DEBUG_ZBOOT. how about this?
>
> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
> index 5e556f7..6fccbf0 100644
> --- a/arch/mips/Kconfig.debug
> +++ b/arch/mips/Kconfig.debug
> @@ -104,7 +104,7 @@ config RUNTIME_DEBUG
>
> config DEBUG_ZBOOT
> bool "Enable compressed kernel support debugging"
> - depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT_UART16550
> + depends on DEBUG_KERNEL
>
oh, no, this dependency is also needed: SYS_SUPPORTS_ZBOOT, so, it
should be:
depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT
> and we keep the old:
>
> ifdef CONFIG_DEBUG_ZBOOT
> obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> endif
>
> If a new serial port is needed, we just need to add the following lines
> to arch/mips/Kconfig
>
> config SYS_SUPPORTS_ZBOOT_UARTXXX
> bool
> select SYS_SUPPORTS_ZBOOT
>
> config MACH_XXXX
> [...]
> select SYS_SUPPORTS_ZBOOT_UARTXXX
> [...]
>
> and in arch/mips/boot/compressed/Makfefile
>
> ifdef CONFIG_DEBUG_ZBOOT
> obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UARTXXX) += $(obj)/uart-xxx.o
> endif
>
> and also a new arch/mips/boot/compressed/uar-xxx.c is needed.
>
> If this is okay, I will send a new revision asap.
>
> Regards,
> Wu Zhangjin
next prev parent reply other threads:[~2010-01-26 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 15:02 [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support Wu Zhangjin
2010-01-26 15:02 ` [PATCH -queue] MIPS: Simplify the weak annotation with __weak Wu Zhangjin
2010-01-27 14:05 ` Ralf Baechle
2010-01-26 15:28 ` [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support Manuel Lauss
2010-01-26 15:28 ` Manuel Lauss
2010-01-26 15:58 ` Wu Zhangjin
2010-01-26 15:58 ` Wu Zhangjin
2010-01-26 16:01 ` Wu Zhangjin [this message]
2010-01-26 16:01 ` Wu Zhangjin
2010-01-26 16:30 ` Manuel Lauss
2010-01-26 16:30 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264521679.24895.30.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).