From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 26 Jan 2010 17:07:28 +0100 (CET) Received: from mail-px0-f181.google.com ([209.85.216.181]:61786 "EHLO mail-px0-f181.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1493366Ab0AZQHY (ORCPT ); Tue, 26 Jan 2010 17:07:24 +0100 Received: by pxi11 with SMTP id 11so3463526pxi.22 for ; Tue, 26 Jan 2010 08:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=7VB56DLezdSktQD/grvI8gg1tFRHtIEnz07mFfCYeDY=; b=dp65Ydem8+i/MgkNFeqhy4InLkAc5SGEvLvyZp8c/ix1wF9sgutHczUkoSFWU68oUN SxmK/Ju47cHNMgrHXpIM+ZxMBXUy+daTInvKbXUFvPWaLlDsQy2obcb2faOo9KanaCv0 JQqgBI1bwCuLwSImI7/0jhYrpiEOf989xPXvA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=M4nXKRmVh2JmGcI5F2C4vigYTEaxhb4vEaW0j3yXD89+IYWRL7MtyT7g4jhxSX1+y4 7PlMrrtXsitCptetbzsPhS6Q23l9i+3cKLfhgkdHawiY/39GwhDZr4xEE/YoB1aC+Xjp bOxjPWi8lAPq438glkJ4Yt/SkEb7sT6qnVKmM= Received: by 10.140.180.20 with SMTP id c20mr5738528rvf.133.1264522037192; Tue, 26 Jan 2010 08:07:17 -0800 (PST) Received: from ?192.168.2.212? ([202.201.14.140]) by mx.google.com with ESMTPS id 20sm4729900pzk.5.2010.01.26.08.07.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 26 Jan 2010 08:07:16 -0800 (PST) Subject: Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support From: Wu Zhangjin Reply-To: wuzhangjin@gmail.com To: Manuel Lauss Cc: Ralf Baechle , linux-mips@linux-mips.org In-Reply-To: <1264521494.24895.28.camel@falcon> References: <8c337354c30ac911207df81abd13197c897b2380.1264517495.git.wuzhangjin@gmail.com> <1264521494.24895.28.camel@falcon> Content-Type: text/plain; charset="UTF-8" Organization: DSLab, Lanzhou University, China Date: Wed, 27 Jan 2010 00:01:19 +0800 Message-ID: <1264521679.24895.30.camel@falcon> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 7bit X-archive-position: 25678 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: wuzhangjin@gmail.com Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 16779 On Tue, 2010-01-26 at 23:58 +0800, Wu Zhangjin wrote: > On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote: > > Hi, > > > > On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin wrote: > > > Changes from v1 (feedbacks from Ralf): > > > > > > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL > > > > > > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the > > > > Not every chip has a standard 16550, unfortunately. I liked your > > first iteration better: > > DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another > > (invisible) > > config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550 > > for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported > > chips). > > > > Yes, It will be not convenient for a new serial port debugging support > with the current modification, for example, if you add UARTXXXX, we need > to select it for the new board and also add it under the "depends" of > DEBUG_ZBOOT. how about this? > > diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug > index 5e556f7..6fccbf0 100644 > --- a/arch/mips/Kconfig.debug > +++ b/arch/mips/Kconfig.debug > @@ -104,7 +104,7 @@ config RUNTIME_DEBUG > > config DEBUG_ZBOOT > bool "Enable compressed kernel support debugging" > - depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT_UART16550 > + depends on DEBUG_KERNEL > oh, no, this dependency is also needed: SYS_SUPPORTS_ZBOOT, so, it should be: depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT > and we keep the old: > > ifdef CONFIG_DEBUG_ZBOOT > obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > endif > > If a new serial port is needed, we just need to add the following lines > to arch/mips/Kconfig > > config SYS_SUPPORTS_ZBOOT_UARTXXX > bool > select SYS_SUPPORTS_ZBOOT > > config MACH_XXXX > [...] > select SYS_SUPPORTS_ZBOOT_UARTXXX > [...] > > and in arch/mips/boot/compressed/Makfefile > > ifdef CONFIG_DEBUG_ZBOOT > obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UARTXXX) += $(obj)/uart-xxx.o > endif > > and also a new arch/mips/boot/compressed/uar-xxx.c is needed. > > If this is okay, I will send a new revision asap. > > Regards, > Wu Zhangjin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-px0-f181.google.com ([209.85.216.181]:61786 "EHLO mail-px0-f181.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1493366Ab0AZQHY (ORCPT ); Tue, 26 Jan 2010 17:07:24 +0100 Subject: Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support From: Wu Zhangjin Reply-To: wuzhangjin@gmail.com In-Reply-To: <1264521494.24895.28.camel@falcon> References: <8c337354c30ac911207df81abd13197c897b2380.1264517495.git.wuzhangjin@gmail.com> <1264521494.24895.28.camel@falcon> Content-Type: text/plain; charset="UTF-8" Date: Wed, 27 Jan 2010 00:01:19 +0800 Message-ID: <1264521679.24895.30.camel@falcon> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org Return-Path: To: Manuel Lauss Cc: Ralf Baechle , linux-mips@linux-mips.org Message-ID: <20100126160119.EClooXhvk_91VB5bLto1ZP4fGKPx_ISh5u0-zLwEuUo@z> On Tue, 2010-01-26 at 23:58 +0800, Wu Zhangjin wrote: > On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote: > > Hi, > > > > On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin wrote: > > > Changes from v1 (feedbacks from Ralf): > > > > > > o make DEBUG_ZBOOT also depend on DEBUG_KERNEL > > > > > > o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the > > > > Not every chip has a standard 16550, unfortunately. I liked your > > first iteration better: > > DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL) another > > (invisible) > > config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550 > > for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported > > chips). > > > > Yes, It will be not convenient for a new serial port debugging support > with the current modification, for example, if you add UARTXXXX, we need > to select it for the new board and also add it under the "depends" of > DEBUG_ZBOOT. how about this? > > diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug > index 5e556f7..6fccbf0 100644 > --- a/arch/mips/Kconfig.debug > +++ b/arch/mips/Kconfig.debug > @@ -104,7 +104,7 @@ config RUNTIME_DEBUG > > config DEBUG_ZBOOT > bool "Enable compressed kernel support debugging" > - depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT_UART16550 > + depends on DEBUG_KERNEL > oh, no, this dependency is also needed: SYS_SUPPORTS_ZBOOT, so, it should be: depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT > and we keep the old: > > ifdef CONFIG_DEBUG_ZBOOT > obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > endif > > If a new serial port is needed, we just need to add the following lines > to arch/mips/Kconfig > > config SYS_SUPPORTS_ZBOOT_UARTXXX > bool > select SYS_SUPPORTS_ZBOOT > > config MACH_XXXX > [...] > select SYS_SUPPORTS_ZBOOT_UARTXXX > [...] > > and in arch/mips/boot/compressed/Makfefile > > ifdef CONFIG_DEBUG_ZBOOT > obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o > +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UARTXXX) += $(obj)/uart-xxx.o > endif > > and also a new arch/mips/boot/compressed/uar-xxx.c is needed. > > If this is okay, I will send a new revision asap. > > Regards, > Wu Zhangjin