From: Wu Zhangjin <wuzhangjin@gmail.com>
To: "dengcheng.zhu" <dengcheng.zhu@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu,
acme@redhat.com, jamie.iles@picochip.com
Subject: Re: [PATCH 3/3] MIPS: implement hardware perf event support
Date: Sat, 17 Apr 2010 13:04:21 +0800 [thread overview]
Message-ID: <1271480661.1860.36.camel@falcon> (raw)
In-Reply-To: <u2p1b4d75291004161849z3e9ff5afw8dc64226e82fb1ac@mail.gmail.com>
On Sat, 2010-04-17 at 09:49 +0800, dengcheng.zhu wrote:
[...]
> >
> > I think it will not work on rm9000 and loongson2 for their performance
> > counters are different from mipsxx. so suggest you only enable this for
> > mipsxxx(refer to arch/mips/oprofile/Makefile) via #ifdef and renaming
> > the current perf_event.c to perf_event_mipsxx.c.
> OK, I'll try to move the control/count help functions/defines and the
> specific mips_pmu stuff into a file called perf_event_mipsxx.c, and leave
> the common things in perf_event.c, so that when we implement Perf for
> loongson2 or rm9000, we can simply add new files like
> perf_event_loongson2.c.
>
> > And to reduce the source code duplication, perhaps we need a solution to
> > share the source code between Oprofile and Perf, and also among mipsxx,
> > rm9000 and loongson2.
> I think there is almost nothing for the count/control things which can be
> shared among mipsxx/rm9000/loongson2. As for sharing between Oprofile and
> Perf, how about moving mipsxx/rm9000/loongson2 count/control things into a
> new file asm/pmu.h, where we use #ifdef's.
>
It looks good, based on your work, I will try to add the loongson2
specific perf support, then we can get more details about the common
parts.
Regards,
Wu Zhangjin
prev parent reply other threads:[~2010-04-17 5:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 16:39 [PATCH 3/3] MIPS: implement hardware perf event support Deng-Cheng Zhu
2010-04-15 17:47 ` Wu Zhangjin
2010-04-17 1:49 ` dengcheng.zhu
2010-04-17 5:04 ` Wu Zhangjin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271480661.1860.36.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dengcheng.zhu@gmail.com \
--cc=jamie.iles@picochip.com \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox