From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Oprofile: Loongson: Fixup of irq handler
Date: Sun, 09 May 2010 09:35:19 +0800 [thread overview]
Message-ID: <1273368919.4914.0.camel@localhost> (raw)
In-Reply-To: <1273165186-29153-1-git-send-email-wuzhangjin@gmail.com>
Hi, Ralf
This one is urgent, could you please review it, thanks ;)
Regards,
Wu Zhangjin
On Fri, 2010-05-07 at 00:59 +0800, Wu Zhangjin wrote:
> The interrupt enable bit of performance counters of Loongson is in the
> control register($24), not in the counter register, so, in
> loongson2_perfcount_handler(), we need to use
>
> enabled = read_c0_perfctrl() & LOONGSON2_PERFCNT_INT_EN;
>
> instead of
>
> enabled = read_c0_perfcnt() & LOONGSON2_PERFCNT_INT_EN;
>
> Reported-by: Xu Hengyang <hengyang@mail.ustc.edu.cn>
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
> arch/mips/oprofile/op_model_loongson2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/oprofile/op_model_loongson2.c b/arch/mips/oprofile/op_model_loongson2.c
> index 29e2326..fa3bf66 100644
> --- a/arch/mips/oprofile/op_model_loongson2.c
> +++ b/arch/mips/oprofile/op_model_loongson2.c
> @@ -122,7 +122,7 @@ static irqreturn_t loongson2_perfcount_handler(int irq, void *dev_id)
> */
>
> /* Check whether the irq belongs to me */
> - enabled = read_c0_perfcnt() & LOONGSON2_PERFCNT_INT_EN;
> + enabled = read_c0_perfctrl() & LOONGSON2_PERFCNT_INT_EN;
> if (!enabled)
> return IRQ_NONE;
> enabled = reg.cnt1_enabled | reg.cnt2_enabled;
next prev parent reply other threads:[~2010-05-09 1:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 16:59 [PATCH] Oprofile: Loongson: Fixup of irq handler Wu Zhangjin
2010-05-09 1:35 ` Wu Zhangjin [this message]
2010-05-11 10:00 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273368919.4914.0.camel@localhost \
--to=wuzhangjin@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox