Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Arnaud Patard <apatard@mandriva.com>,
	linux-mips@linux-mips.org, rtc-linux@googlegroups.com,
	david-b@pacbell.net, a.zummo@towertech.it,
	akpm@linux-foundation.org
Subject: Re: [PATCH] rtc-cmos: Fix binary mode support
Date: Mon, 17 May 2010 22:55:54 +0800	[thread overview]
Message-ID: <1274108154.14193.3.camel@localhost> (raw)
In-Reply-To: <20100511141039.GG13576@linux-mips.org>

Hi, Ralf and Arnaud

Just found a bug introduced in this patch, please take a look at the 754
line after applying it, a ";" is needed to append the "dev_warn(dev,
"only 24-hr supported\n")".

Regards,
	Wu Zhangjin

On Tue, 2010-05-11 at 15:10 +0100, Ralf Baechle wrote:
> On Thu, Apr 29, 2010 at 11:58:44AM +0200, Arnaud Patard wrote:
> 
> > [ I'm sending again this patch, hoping it'll get reviewed ]
> 
> I'm showing mercy for the poor sod of a patch by merging it into -my tree
> for -next.
> 
> Thanks Arnaud,
> 
>   Ralf
> 

  reply	other threads:[~2010-05-17 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-29  9:58 [PATCH] rtc-cmos: Fix binary mode support Arnaud Patard
2010-05-11 14:10 ` Ralf Baechle
2010-05-17 14:55   ` Wu Zhangjin [this message]
2010-05-17 15:03     ` Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2010-04-16  9:19 Arnaud Patard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274108154.14193.3.camel@localhost \
    --to=wuzhangjin@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=apatard@mandriva.com \
    --cc=david-b@pacbell.net \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox