From: Robert Millan <rmh@gnu.org>
To: linux-mips@linux-mips.org
Subject: [PATCH] removed ad-hoc cmdline default
Date: Sun, 07 Nov 2010 13:38:29 +0100 [thread overview]
Message-ID: <1289133509.1547.1@thorin> (raw)
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
Loongson builds have an ad-hoc cmdline default of "console=ttyS0,115200
root=/dev/hda1". These settings come from vendor (I remember builds
from Lemote branch requiring a "console=tty" override in order to get a
working console).
At least on my Yeeloong, they're particularly useless: there's no
(external) serial port, and the IDE drive is now recognised as /dev/
sda.
I recommend removing them. They make sense from a distributor/vendor
POV but otherwise are just a nuissance.
[-- Attachment #2: loongson_cmdline.diff --]
[-- Type: text/x-patch, Size: 612 bytes --]
Remove ad-hoc cmdline settings.
Signed-off-by: Robert Millan <rmh@gnu.org>
diff --git a/arch/mips/loongson/common/cmdline.c b/arch/mips/loongson/common/cmdline.c
index 1a06def..353e1d2 100644
--- a/arch/mips/loongson/common/cmdline.c
+++ b/arch/mips/loongson/common/cmdline.c
@@ -44,10 +44,5 @@ void __init prom_init_cmdline(void)
strcat(arcs_cmdline, " ");
}
- if ((strstr(arcs_cmdline, "console=")) == NULL)
- strcat(arcs_cmdline, " console=ttyS0,115200");
- if ((strstr(arcs_cmdline, "root=")) == NULL)
- strcat(arcs_cmdline, " root=/dev/hda1");
-
prom_init_machtype();
}
next reply other threads:[~2010-11-07 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 12:38 Robert Millan [this message]
2010-11-08 22:58 ` [PATCH] removed ad-hoc cmdline default Ralf Baechle
2011-01-24 23:22 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289133509.1547.1@thorin \
--to=rmh@gnu.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox