From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 13 Jun 2011 11:13:26 +0200 (CEST) Received: from mprc.pku.edu.cn ([162.105.203.9]:52881 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491068Ab1FMJNU (ORCPT ); Mon, 13 Jun 2011 11:13:20 +0200 Received: from [192.168.0.106] ([162.105.80.111]) (authenticated bits=0) by mprc.pku.edu.cn (8.13.8/8.13.8) with ESMTP id p5D995YN010394; Mon, 13 Jun 2011 17:09:08 +0800 Subject: Re: [PATCH] PCI: Make the struct pci_dev * argument of pci_fixup_irqs const. From: Guan Xuetao Reply-To: gxt@mprc.pku.edu.cn To: Ralf Baechle Cc: Jesse Barnes , linux-pci@vger.kernel.org, Anton Vorontsov , Chris Metcalf , Colin Cross , "David S. Miller" , Eric Miao , Erik Gilling , "H. Peter Anvin" , Imre Kaloz , Ingo Molnar , Ivan Kokshaysky , Krzysztof Halasa , Lennert Buytenhek , Matt Turner , Nicolas Pitre , Olof Johansson , Paul Mundt , Richard Henderson , Russell King , Thomas Gleixner , Andrew Morton , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org In-Reply-To: <20110610143021.GA26043@linux-mips.org> References: <20110610143021.GA26043@linux-mips.org> Content-Type: text/plain; charset="UTF-8" Organization: MPRC, PKU Date: Mon, 13 Jun 2011 17:00:44 +0800 Message-ID: <1307955644.1878.5.camel@epip-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit X-archive-position: 30364 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: gxt@mprc.pku.edu.cn Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 10464 On Fri, 2011-06-10 at 15:30 +0100, Ralf Baechle wrote: > Aside of the usual motivation for constification, this function has a > history of being abused a hook for interrupt and other fixups so I turned > this function const ages ago in the MIPS code but it should be done > treewide. > > Due to function pointer passing in varous places a few other functions > had to be constified as well. > > Signed-off-by: Ralf Baechle > To: Anton Vorontsov > To: Chris Metcalf > To: Colin Cross > To: "David S. Miller" > To: Eric Miao > To: Erik Gilling > To: Guan Xuetao > To: "H. Peter Anvin" > To: Imre Kaloz > To: Ingo Molnar > To: Ivan Kokshaysky > To: Jesse Barnes > To: Krzysztof Halasa > To: Lennert Buytenhek > To: Matt Turner > To: Nicolas Pitre > To: Olof Johansson > To: Paul Mundt > To: Richard Henderson > To: Russell King > To: Thomas Gleixner > Cc: Andrew Morton > Cc: linux-alpha@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: x86@kernel.org > --- For UniCore32 related codes: Acked-by: Guan Xuetao