From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org,
David Woodhouse <dwmw2@infradead.org>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH V2 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are at least 64K
Date: Mon, 19 Dec 2011 12:56:32 +0200 [thread overview]
Message-ID: <1324292192.32675.6.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1324290964-14096-1-git-send-email-jonas.gorski@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Mon, 2011-12-19 at 11:36 +0100, Jonas Gorski wrote:
> The CFE boot loader on BCM63XX platforms assumes itself and the NVRAM
> partition to be 64 KiB (or erase block sized, if larger).
> Ensure this assumption is also met when creating the partitions to
> prevent accidential erasure of CFE or NVRAM.
>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
If someone creates a partition smaller than 64 KiB, then why it is
better to silently make it 64 KiB (and thus doing not what the user
asked to do and possibly confusing him), rather than returning an error
or just printing a warning?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-19 10:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 12:58 [PATCH 0/5] MTD: bcm63xxpart: improve robustness Jonas Gorski
2011-12-17 12:58 ` [PATCH 1/5] MTD: bcm63xxpart: check version marker string for newer CFEs Jonas Gorski
2011-12-17 12:58 ` [PATCH 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are at least 64K Jonas Gorski
2011-12-17 13:13 ` Guillaume LECERF
2011-12-17 13:27 ` Jonas Gorski
2011-12-17 14:32 ` Guillaume LECERF
2011-12-17 21:33 ` Artem Bityutskiy
2011-12-17 21:57 ` Jonas Gorski
2011-12-18 11:47 ` Artem Bityutskiy
2011-12-19 10:36 ` [PATCH V2 " Jonas Gorski
2011-12-19 10:56 ` Artem Bityutskiy [this message]
2011-12-19 12:01 ` Jonas Gorski
2011-12-21 20:54 ` Artem Bityutskiy
2011-12-17 12:58 ` [PATCH 3/5] MTD: bcm63xxpart: don't assume NVRAM is always the fourth partition Jonas Gorski
2011-12-17 12:58 ` [PATCH 4/5] MIPS: BCM63XX: bcm963xx_tag.h: make crc fields integers Jonas Gorski
2011-12-17 12:58 ` [PATCH 5/5] MTD: bcm63xxpart: check the image tag's crc32 Jonas Gorski
2011-12-17 21:40 ` [PATCH 0/5] MTD: bcm63xxpart: improve robustness Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324292192.32675.6.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox