From: Keith Owens <kaos@sgi.com>
To: ilya@theIlya.com
Cc: wesolows@foobazco.org, linux-mips@linux-mips.org
Subject: Re: Yet another fix
Date: Mon, 02 Jun 2003 14:49:24 +1000 [thread overview]
Message-ID: <13249.1054529364@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sun, 01 Jun 2003 21:14:24 MST." <20030602041424.GG3035@gateway.total-knowledge.com>
On Sun, 1 Jun 2003 21:14:24 -0700,
ilya@theIlya.com wrote:
>I am not sure this is correct solution to a problem. Or rather, I'm pretty
>sure it is incorrect one.. There is a reference to module_map somewhere, however
>it is not inculded if modules are disabled. Here is sorta fix
>
>Index: include/asm-mips64/module.h
>===================================================================
>RCS file: /home/cvs/linux/include/asm-mips64/module.h,v
>retrieving revision 1.5
>diff -u -r1.5 module.h
>--- include/asm-mips64/module.h 1 Jun 2003 00:39:15 -0000 1.5
>+++ include/asm-mips64/module.h 2 Jun 2003 03:59:23 -0000
>@@ -11,4 +11,8 @@
> #define Elf_Sym Elf32_Sym
> #define Elf_Ehdr Elf32_Ehdr
>
>+#ifndef CONFIG_MODULES
>+#define module_map(x) vmalloc(x)
>+#endif
>+
> #endif /* _ASM_MODULE_H */
That fix is incorrect. There should be no references to module_map
when CONFIG_MODULES=n. Please find out where module_map is being
incorrectly used and fix that code.
next prev parent reply other threads:[~2003-06-02 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-02 4:14 Yet another fix ilya
2003-06-02 4:49 ` Keith Owens [this message]
2003-06-02 4:57 ` ilya
2003-06-02 13:27 ` Keith Owens
2003-06-02 14:12 ` Ralf Baechle
2003-06-02 14:30 ` ilya
2003-06-02 23:50 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13249.1054529364@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=ilya@theIlya.com \
--cc=linux-mips@linux-mips.org \
--cc=wesolows@foobazco.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox