Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Matt Turner <mattst88@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, Matt Turner <mattst88@gmail.com>
Subject: [PATCH] mips: set ST0_MX flag for MDMX
Date: Thu,  3 May 2012 18:40:45 -0400	[thread overview]
Message-ID: <1336084845-28995-1-git-send-email-mattst88@gmail.com> (raw)

As the comment in commit 3301edcb says, DSP and MDMX share the same
config flag bit.

Without this set, MDMX instructions cause Illegal instruction errors.

Signed-off-by: Matt Turner <mattst88@gmail.com>
---
Is MDMX implemented by anything other than some Broadcom CPUs? Is it
totally replaced by DSP?

I had a terrible time finding any documentation on it (which is annoying
because Volume IV-b covering MDMX is referenced by all the MIPS64 documents.)
but finally found a copy here: www.enlight.ru/docs/cpu/risc/mips/MDMXspec.pdf

If it's dead, it's too bad because it's a pretty cool ISA.

 arch/mips/kernel/traps.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index cfdaaa4..89ead75 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -1548,7 +1548,7 @@ void __cpuinit per_cpu_trap_init(void)
 #endif
 	if (current_cpu_data.isa_level == MIPS_CPU_ISA_IV)
 		status_set |= ST0_XX;
-	if (cpu_has_dsp)
+	if (cpu_has_dsp || cpu_has_mdmx)
 		status_set |= ST0_MX;
 
 	change_c0_status(ST0_CU|ST0_MX|ST0_RE|ST0_FR|ST0_BEV|ST0_TS|ST0_KX|ST0_SX|ST0_UX,
-- 
1.7.3.4

             reply	other threads:[~2012-05-03 22:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03 22:40 Matt Turner [this message]
2012-05-04 11:16 ` [PATCH] mips: set ST0_MX flag for MDMX Sergei Shtylyov
2012-05-05 22:22   ` Matt Turner
2012-05-09 17:20 ` Maciej W. Rozycki
2012-05-09 19:21   ` Matt Turner
2012-05-19 17:59     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336084845-28995-1-git-send-email-mattst88@gmail.com \
    --to=mattst88@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox