From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ralf Baechle <ralf@linux-mips.org>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 01/10] of/irq: Rework of_irq_count()
Date: Wed, 18 Sep 2013 15:24:43 +0200 [thread overview]
Message-ID: <1379510692-32435-2-git-send-email-treding@nvidia.com> (raw)
In-Reply-To: <1379510692-32435-1-git-send-email-treding@nvidia.com>
The of_irq_to_resource() helper that is used to implement of_irq_count()
tries to resolve interrupts and in fact creates a mapping for resolved
interrupts. That's pretty heavy lifting for something that claims to
just return the number of interrupts requested by a given device node.
Instead, use the more lightweight of_irq_map_one(), which, despite the
name, doesn't create an actual mapping. Perhaps a better name would be
of_irq_translate_one().
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/of/irq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 1752988..5f44388 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -368,9 +368,10 @@ EXPORT_SYMBOL_GPL(of_irq_to_resource);
*/
int of_irq_count(struct device_node *dev)
{
+ struct of_irq irq;
int nr = 0;
- while (of_irq_to_resource(dev, nr, NULL))
+ while (of_irq_map_one(dev, nr, &irq) == 0)
nr++;
return nr;
--
1.8.4
next prev parent reply other threads:[~2013-09-18 13:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 13:24 [PATCH v2 00/10] of/irq: Defer interrupt reference resolution Thierry Reding
2013-09-18 13:24 ` Thierry Reding [this message]
2013-09-22 21:19 ` [PATCH v2 01/10] of/irq: Rework of_irq_count() Rob Herring
2013-09-22 21:19 ` Rob Herring
2013-10-15 22:42 ` Grant Likely
2013-10-15 22:42 ` Grant Likely
2013-10-15 22:55 ` Grant Likely
2013-10-15 22:55 ` Grant Likely
2013-09-18 13:24 ` [PATCH v2 02/10] of/irq: Use irq_of_parse_and_map() Thierry Reding
2013-09-22 21:17 ` Rob Herring
2013-09-22 21:17 ` Rob Herring
2013-09-18 13:24 ` [PATCH v2 03/10] irqdomain: Introduce __irq_create_mapping() Thierry Reding
2013-09-18 13:24 ` [PATCH v2 04/10] irqdomain: Return errors from irq_create_of_mapping() Thierry Reding
2013-09-18 14:23 ` Ralf Baechle
2013-09-22 21:14 ` Rob Herring
2013-09-22 21:14 ` Rob Herring
2013-09-23 8:13 ` Thierry Reding
2013-09-23 8:13 ` Thierry Reding
2013-10-15 23:01 ` Grant Likely
2013-10-15 23:01 ` Grant Likely
2013-09-18 13:24 ` [PATCH v2 05/10] of/irq: Introduce __irq_of_parse_and_map() Thierry Reding
2013-09-18 13:24 ` [PATCH v2 06/10] of/irq: Return errors from of_irq_to_resource() Thierry Reding
2013-09-18 13:24 ` [PATCH v2 07/10] of/irq: Propagate errors in of_irq_to_resource_table() Thierry Reding
2013-09-18 14:23 ` Ralf Baechle
2013-09-22 21:08 ` Rob Herring
2013-09-22 21:08 ` Rob Herring
2013-09-23 8:36 ` Thierry Reding
2013-09-23 8:36 ` Thierry Reding
2013-09-18 13:24 ` [PATCH v2 08/10] of/platform: Resolve interrupt references at probe time Thierry Reding
2013-10-15 23:24 ` Grant Likely
2013-10-16 8:20 ` Thierry Reding
2013-10-24 16:37 ` Grant Likely
2013-10-25 7:35 ` Thierry Reding
2013-09-18 13:24 ` [PATCH v2 09/10] of/i2c: " Thierry Reding
2013-09-18 13:24 ` [PATCH v2 10/10] gpio: tegra: Use module_platform_driver() Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379510692-32435-2-git-send-email-treding@nvidia.com \
--to=thierry.reding@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox