From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 17 Dec 2014 21:58:53 +0100 (CET) Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:35102 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27008382AbaLQU6wBKg7l (ORCPT ); Wed, 17 Dec 2014 21:58:52 +0100 Received: from filter.hostedemail.com (unknown [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 832599EA16; Wed, 17 Dec 2014 20:58:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fang92_872cb68b11256 X-Filterd-Recvd-Size: 5562 Received: from joe-X200MA.home (pool-71-103-235-196.lsanca.fios.verizon.net [71.103.235.196]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Wed, 17 Dec 2014 20:58:48 +0000 (UTC) Message-ID: <1418849927.28384.1.camel@perches.com> Subject: rfc: remove early_printk from a few arches? (blackfin, m68k, mips) From: Joe Perches To: linux-arch Cc: LKML , Geert Uytterhoeven , linux-m68k , Steven Miao , Ralf Baechle , linux-mips Date: Wed, 17 Dec 2014 12:58:47 -0800 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 44714 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: joe@perches.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips It seems like early_printk can be configured into a few architectures but also appear not to be used. $ git grep -w "early_printk" arch/arm/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/arm/kernel/early_printk.c: * linux/arch/arm/kernel/early_printk.c arch/arm/mach-socfpga/socfpga.c: early_printk("Early printk initialized\n"); arch/blackfin/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/blackfin/kernel/bfin_dma.c:#include arch/blackfin/kernel/early_printk.c: * derived from arch/x86/kernel/early_printk.c arch/blackfin/kernel/early_printk.c:#include arch/blackfin/kernel/setup.c:#include arch/blackfin/kernel/shadow_console.c:#include arch/blackfin/mm/init.c:#include arch/ia64/sn/kernel/setup.c: * IO on SN2 is done via SAL calls, early_printk won't work without this. arch/m68k/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/microblaze/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/microblaze/kernel/cpu/cpuinfo-pvr-full.c: early_printk("ERROR: Microblaze " x "-different for PVR and DTS\n"); arch/microblaze/kernel/cpu/cpuinfo-static.c: early_printk("ERROR: Microblaze " x "-different for kernel and DTS\n"); arch/microblaze/kernel/setup.c:/* initialize device tree for usage in early_printk */ arch/mips/ath25/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/mips/ath79/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/mips/bcm63xx/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/mips/include/asm/mach-lantiq/falcon/lantiq_soc.h: * during early_printk no ioremap possible at this early stage arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h: * during early_printk no ioremap is possible arch/mips/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/mips/lantiq/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/mips/loongson/common/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/mips/ralink/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/tile/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/tile/kernel/early_printk.c: early_printk("Kernel panic - not syncing: %pV", &vaf); arch/um/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/unicore32/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/unicore32/kernel/early_printk.c: * linux/arch/unicore32/kernel/early_printk.c arch/x86/kernel/Makefile:obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arch/x86/kernel/e820.c: early_printk(msg); arch/x86/kernel/head64.c: early_printk("Kernel alive\n"); arch/x86/kernel/head_64.S: call early_printk arch/x86/platform/efi/Makefile:obj-$(CONFIG_EARLY_PRINTK_EFI) += early_printk.o drivers/tty/serial/8250/8250_early.c: * and on early_printk.c by Andi Kleen. drivers/tty/serial/sn_console.c: * synchronous (raw) and asynchronous (buffered). initially, early_printk drivers/tty/serial/sn_console.c: /* without early_printk, we may be invoked late enough to race drivers/tty/serial/sn_console.c: /* early_printk invocation may have done this for us */ include/linux/printk.h:void early_printk(const char *fmt, ...); include/linux/printk.h:void early_printk(const char *s, ...) { } kernel/events/core.c: early_printk("perf interrupt took too long (%lld > %lld), lowering " kernel/locking/lockdep.c: * We cannot printk in early bootup code. Not even early_printk() kernel/printk/printk.c:asmlinkage __visible void early_printk(const char *fmt, ...) kernel/printk/printk.c: * early_printk) - sometimes before setup_arch() completes - be careful kernel/printk/printk.c: * There are two types of consoles - bootconsoles (early_printk) and These seem to the only uses: arch/arm/mach-socfpga/socfpga.c: early_printk("Early printk initialized\n"); [] arch/microblaze/kernel/cpu/cpuinfo-pvr-full.c: early_printk("ERROR: Microblaze " x "-different for PVR and DTS\n"); arch/microblaze/kernel/cpu/cpuinfo-static.c: early_printk("ERROR: Microblaze " x "-different for kernel and DTS\n"); [] arch/tile/kernel/early_printk.c: early_printk("Kernel panic - not syncing: %pV", &vaf); [] arch/x86/kernel/e820.c: early_printk(msg); arch/x86/kernel/head64.c: early_printk("Kernel alive\n"); arch/x86/kernel/head_64.S: call early_printk [] kernel/events/core.c: early_printk("perf interrupt took too long (%lld > %lld), lowering " So blackfin, m68k, and mips seems to have it possible to enable, but also don't appear at first glance to use it, Is early_printk really used by these architectures? Should it be removed?