From: Ben Hutchings <ben@decadent.org.uk>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] MIPS: BPF: Disable JIT on R3000 (MIPS-I)
Date: Mon, 05 Oct 2015 12:31:01 +0100 [thread overview]
Message-ID: <1444044661.2730.286.camel@decadent.org.uk> (raw)
In-Reply-To: <20151005092440.GA1389@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Mon, 2015-10-05 at 11:24 +0200, Ralf Baechle wrote:
> On Sat, Sep 05, 2015 at 08:29:28PM +0100, Ben Hutchings wrote:
>
> > The JIT does not include the load delay slots required by MIPS-I
> > processors.
>
> See 0c5d187828588dd1b36cb93b4481a8db467ef3e8 (MIPS: BPF: Fix load delay
> slots.) for a proper fix.
How about all the inlined loads (emit_load, emit_load_byte,
emit_half_load)?
> I'm wondering, how did you find this issue, are you scanning the code
> for broken instruction sequences?
No, I was already looking at the BPF JIT implementation for some other
reason.
Ben.
--
Ben Hutchings
compatible: Gracefully accepts erroneous data from any source
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2015-10-05 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 19:29 [PATCH] MIPS: BPF: Disable JIT on R3000 (MIPS-I) Ben Hutchings
2015-10-05 9:24 ` Ralf Baechle
2015-10-05 9:51 ` Markos Chandras
2015-10-05 9:51 ` Markos Chandras
2015-10-05 11:31 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444044661.2730.286.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox