From: Ben Hutchings <ben@decadent.org.uk>
To: David Decotigny <ddecotig@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-api@vger.kernel.org, linux-mips@linux-mips.org,
fcoe-devel@open-fcoe.org,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Eugenia Emantayev <eugenia@mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Ido Shamay <idos@mellanox.com>, Joe Perches <joe@perches.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Govindarajulu Varadarajan <_govind@gmx.com>,
Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Pravin B Shelar <pshelar@nicira.com>,
Ed Swierk <eswierk@skyportsystems.com>,
Robert Love <robert.w.love@intel.com>,
"James E.Yuval Mintz" <Yuval.Mintz@qlogic.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
David Decotigny <decot@googlers.com>
Subject: Re: [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API
Date: Sat, 13 Feb 2016 01:49:09 +0000 [thread overview]
Message-ID: <1455328149.2801.82.camel@decadent.org.uk> (raw)
In-Reply-To: <1455064168-5102-6-git-send-email-ddecotig@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Tue, 2016-02-09 at 16:29 -0800, David Decotigny wrote:
> From: David Decotigny <decot@googlers.com>
>
> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by
> the new get_ksettings/set_ksettings callbacks. This API provides
> support for most legacy ethtool_cmd fields, adds support for larger
> link mode masks (up to 4064 bits, variable length), and removes
> ethtool_cmd deprecated fields (transceiver/maxrxpkt/maxtxpkt).
[...]
I previously asked you to include 'link' in the command names and
structure name. This would clarify that these are now only for link
settings and reduce the risk of confusion between old and new commands.
However, you didn't reply to that review. Do you have any objection to
doing this?
Ben.
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-02-13 1:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 0:29 [PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 01/19] lib/bitmap.c: conversion routines to/from u32 array David Decotigny
2016-02-13 1:04 ` Ben Hutchings
2016-02-10 0:29 ` [PATCH net-next v8 02/19] test_bitmap: unit tests for lib/bitmap.c David Decotigny
2016-02-13 1:39 ` Ben Hutchings
2016-02-10 0:29 ` [PATCH net-next v8 03/19] net: usnic: remove unused call to ethtool_ops::get_settings David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 04/19] net: usnic: use __ethtool_get_settings David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API David Decotigny
2016-02-13 1:49 ` Ben Hutchings [this message]
2016-02-18 19:49 ` David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 06/19] tx4939: use __ethtool_get_ksettings David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 07/19] net: usnic: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 08/19] net: bonding: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 09/19] net: ipvlan: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 10/19] net: macvlan: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 11/19] net: team: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 12/19] net: fcoe: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 13/19] net: rdma: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 14/19] net: 8021q: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 15/19] net: bridge: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 16/19] net: core: " David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 17/19] net: ethtool: remove unused __ethtool_get_settings David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 18/19] net: mlx4: convenience predicate for debug messages David Decotigny
2016-02-10 0:29 ` [PATCH net-next v8 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API David Decotigny
2016-02-11 0:56 ` [PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455328149.2801.82.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=VenkatKumar.Duvvuru@Emulex.Com \
--cc=Yuval.Mintz@qlogic.com \
--cc=_govind@gmx.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ddecotig@gmail.com \
--cc=decot@googlers.com \
--cc=edumazet@google.com \
--cc=eswierk@skyportsystems.com \
--cc=eugenia@mellanox.co.il \
--cc=fcoe-devel@open-fcoe.org \
--cc=idos@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=robert.w.love@intel.com \
--cc=saeedm@mellanox.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox