From: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
To: Jonas Gorski <jogo@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Kevin Cernekee <cernekee@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
John Crispin <john@phrozen.org>,
Paul Burton <paul.burton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>, Alban Bedel <albeu@free.fr>
Subject: Re: [PATCH 2/2] MIPS: store the appended dtb address in a variable
Date: Fri, 17 Jun 2016 09:56:36 -0700 [thread overview]
Message-ID: <1466182596.5921.5.camel@chimera> (raw)
In-Reply-To: <1466165260-6897-3-git-send-email-jogo@openwrt.org>
On Fri, 2016-06-17 at 14:07 +0200, Jonas Gorski wrote:
> +++ b/arch/mips/pic32/pic32mzda/init.c
> @@ -33,8 +33,8 @@ static ulong get_fdtaddr(void)
> {
> ulong ftaddr = 0;
>
> - if ((fw_arg0 == -2) && fw_arg1 && !fw_arg2 && !fw_arg3)
> - return (ulong)fw_arg1;
> + if (fw_passed_dtb && !fw_arg2 && !fw_arg3)
> + return (ulong)fw_passed_dtb;
This part potentially violates the UHI spec. If fw_passed_dtb is valid
but fw_arg0 > 0, fw_arg2 may still be a valid envp. Comparing otherwise
undefined values to zero is also incorrect.
next prev parent reply other threads:[~2016-06-17 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 12:07 [PATCH 0/2] MIPS: keep firmwmare arguments with appended dtb Jonas Gorski
2016-06-17 12:07 ` [PATCH 1/2] MIPS: ZBOOT: copy appended dtb to the end of the kernel Jonas Gorski
2016-06-17 14:01 ` Antony Pavlov
2016-06-17 14:44 ` Jonas Gorski
2016-06-17 15:06 ` Antony Pavlov
2016-06-17 12:07 ` [PATCH 2/2] MIPS: store the appended dtb address in a variable Jonas Gorski
2016-06-17 16:56 ` Daniel Gimpelevich [this message]
2016-06-20 9:31 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466182596.5921.5.camel@chimera \
--to=daniel@gimpelevich.san-francisco.ca.us \
--cc=albeu@free.fr \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=jogo@openwrt.org \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox