From: Joe Perches <joe@perches.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
linux-mips@linux-mips.org,
Dragan Cecavac <dragan.cecavac@mips.com>,
Aleksandar Markovic <aleksandar.markovic@mips.com>,
Douglas Leung <douglas.leung@mips.com>,
Goran Ferenc <goran.ferenc@mips.com>,
James Hogan <james.hogan@mips.com>,
James Hogan <jhogan@kernel.org>,
linux-kernel@vger.kernel.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Paul Burton <paul.burton@imgtec.com>,
Paul Burton <paul.burton@mips.com>,
Petar Jovanovic <petar.jovanovic@mips.com>,
Raghu Gandham <raghu.gandham@mips.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo
Date: Fri, 20 Oct 2017 14:08:56 -0700 [thread overview]
Message-ID: <1508533736.30181.7.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1710202148280.3886@tp.orcam.me.uk>
On Fri, 2017-10-20 at 21:52 +0100, Maciej W. Rozycki wrote:
> On Fri, 20 Oct 2017, Joe Perches wrote:
>
> > > diff --git a/arch/mips/kernel/proc.c b/arch/mips/kernel/proc.c
> > > index bd9bf52..99f9aab 100644
> > > --- a/arch/mips/kernel/proc.c
> > > +++ b/arch/mips/kernel/proc.c
> > > @@ -58,7 +58,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
> > >
> > > seq_printf(m, "processor\t\t: %ld\n", n);
> > > sprintf(fmt, "cpu model\t\t: %%s V%%d.%%d%s\n",
> > > - cpu_data[n].options & MIPS_CPU_FPU ? " FPU V%d.%d" : "");
> > > + cpu_data[n].options & MIPS_CPU_FPU ? " FPU V%d.%d" : "");
> > > seq_printf(m, fmt, __cpu_name[n],
> > > (version >> 4) & 0x0f, version & 0x0f,
> > > (fp_vers >> 4) & 0x0f, fp_vers & 0x0f);
> >
> > That's somewhat unpleasant code as it formats a fmt string
> > and the compiler can not verify fmt and args.
> >
> > Perhaps something like the below is preferable:
>
> Hmm, what problem exactly are you trying to solve with code that has
> worked just fine for 16 years now?
The compiler cannot verify fmt and args.
next prev parent reply other threads:[~2017-10-20 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 14:20 [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo Aleksandar Markovic
2017-10-20 15:17 ` Joe Perches
2017-10-20 20:52 ` Maciej W. Rozycki
2017-10-20 20:52 ` Maciej W. Rozycki
2017-10-20 21:08 ` Joe Perches [this message]
2017-10-20 21:46 ` Maciej W. Rozycki
2017-10-20 21:46 ` Maciej W. Rozycki
2017-10-20 23:09 ` Joe Perches
2017-10-20 20:47 ` Maciej W. Rozycki
2017-10-20 20:47 ` Maciej W. Rozycki
2017-10-20 23:56 ` David Daney
2017-10-23 7:54 ` Miodrag Dinic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508533736.30181.7.camel@perches.com \
--to=joe@perches.com \
--cc=aleksandar.markovic@mips.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=douglas.leung@mips.com \
--cc=dragan.cecavac@mips.com \
--cc=goran.ferenc@mips.com \
--cc=james.hogan@mips.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
--cc=miodrag.dinic@mips.com \
--cc=paul.burton@imgtec.com \
--cc=paul.burton@mips.com \
--cc=petar.jovanovic@mips.com \
--cc=raghu.gandham@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox