Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase
Date: Sat, 17 Mar 2018 19:43:48 +0800	[thread overview]
Message-ID: <1521287028.20119.2.camel@flygoat.com> (raw)
In-Reply-To: <1521186916-13745-1-git-send-email-chenhc@lemote.com>

在 2018-03-16五的 15:55 +0800,Huacai Chen写道:
> Call __stack_chk_guard_setup() in decompress_kernel() is too late
> that
> stack checking always fails for decompress_kernel() itself. So remove
> __stack_chk_guard_setup() and initialize __stack_chk_guard before we
> call decompress_kernel().
> 
> Original code comes from ARM but also used for MIPS and SH, so fix
> them
> together. If without this fix, compressed booting of these archs will
> fail because stack checking is enabled by default (>=4.16).
> 
> V2: Fix build on ARM.
> V3: Fix build on SuperH.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Huacai Chen <chenhc@lemote.com>

Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

It works fine on MIPS(Loongson-3A3000) and arm (Allwinner H3)
platforms.

Thanks!
> ---
>  arch/arm/boot/compressed/head.S        | 4 ++++
>  arch/arm/boot/compressed/misc.c        | 7 -------
>  arch/mips/boot/compressed/decompress.c | 7 -------
>  arch/mips/boot/compressed/head.S       | 4 ++++
>  arch/sh/boot/compressed/head_32.S      | 8 ++++++++
>  arch/sh/boot/compressed/head_64.S      | 4 ++++
>  arch/sh/boot/compressed/misc.c         | 7 -------
>  7 files changed, 20 insertions(+), 21 deletions(-)
> 
-- 
Jiaxun Yang <jiaxun.yang@flygoat.com>

  parent reply	other threads:[~2018-03-17 11:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180316075352epcas5p3d95b13f9382ff7bbce83b8177e8e3ad6@epcas5p3.samsung.com>
2018-03-16  7:55 ` [PATCH V3] ZBOOT: fix stack protector in compressed boot phase Huacai Chen
2018-03-16 22:13   ` Andrew Morton
2018-03-16 23:13     ` Rich Felker
2018-03-17 11:43   ` Jiaxun Yang [this message]
2018-03-22 22:21   ` James Hogan
2018-03-23  3:50     ` Jiaxun Yang
2018-03-23 21:08       ` James Hogan
2018-03-23  8:14   ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521287028.20119.2.camel@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox