From: Florian Fainelli <florian@openwrt.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH 0/8] Add basic support for BCM6328
Date: Tue, 12 Jun 2012 13:26:44 +0200 [thread overview]
Message-ID: <1525623.di3mH0BcIS@flexo> (raw)
In-Reply-To: <1339489425-19037-1-git-send-email-jonas.gorski@gmail.com>
Hi Jonas,
On Tuesday 12 June 2012 10:23:37 Jonas Gorski wrote:
> This patchset adds basic support for BCM6328 and its PCIe port.
>
> The BCM6328 is an ADSL2+ SoC with support for NAND and SPI flash,
> integrated five port ethernet switch, and one PCIe port.
>
> Patches 1 and 2 add generic flash type detection, as different chips
> support different flash types, and the BCM6328 does not support
> parallel CFI flashes.
>
> Patches 3-4 add support for detecting and handling the BCM6328 itself.
> This allows booting to command line.
>
> Patches 5-7 add support for the PCIe port of the BCM6328 and expose
> the PCIe port driver for MIPS (I wonder what is so special about it
> that it isn't included in the standard PCI drivers).
>
> Patch 8 then adds a 6328 reference board definition, so one can actually
> boot to command line.
Your patchset looks good to me. Feel free to add my Reviewed-by: Florian
Fainelli <florian@openwrt.org> tag to it.
Thanks!
>
> Jonas Gorski (8):
> MIPS: BCM63XX: move flash registration out of board_bcm963xx.c
> MIPS: BCM63XX: add flash type detection
> MIPS: BCM63XX: use the Chip ID register for identifying the SoC
> MIPS: BCM63XX: add basic BCM6328 CPU support
> MIPS: BCM63XX: Move the PCI initialization into its own function
> MIPS: BCM63XX: Add PCIe Support for BCM6328
> MIPS: expose PCIe drivers for MIPS
> MIPS: BCM63XX: add 96328avng reference board
>
> arch/mips/Kconfig | 2 +
> arch/mips/bcm63xx/Kconfig | 4 +
> arch/mips/bcm63xx/Makefile | 4 +-
> arch/mips/bcm63xx/boards/board_bcm963xx.c | 106 ++++++++--------
> arch/mips/bcm63xx/cpu.c | 63 ++++++++--
> arch/mips/bcm63xx/dev-flash.c | 123 ++++++++++++++++++
> arch/mips/bcm63xx/dev-spi.c | 2 +-
> arch/mips/bcm63xx/irq.c | 21 +++
> arch/mips/bcm63xx/prom.c | 4 +-
> arch/mips/bcm63xx/setup.c | 13 ++-
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_cpu.h | 120
+++++++++++++++++-
> .../include/asm/mach-bcm63xx/bcm63xx_dev_flash.h | 12 ++
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h | 2 +
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_io.h | 8 ++
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h | 117 +++++++++++++++++
> arch/mips/include/asm/mach-bcm63xx/ioremap.h | 1 +
> arch/mips/pci/ops-bcm63xx.c | 61 +++++++++
> arch/mips/pci/pci-bcm63xx.c | 133
+++++++++++++++++++-
> arch/mips/pci/pci-bcm63xx.h | 5 +
> 19 files changed, 729 insertions(+), 72 deletions(-)
> create mode 100644 arch/mips/bcm63xx/dev-flash.c
> create mode 100644 arch/mips/include/asm/mach-bcm63xx/bcm63xx_dev_flash.h
>
> --
> 1.7.2.5
>
--
Florian
prev parent reply other threads:[~2012-06-12 11:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 8:23 [PATCH 0/8] Add basic support for BCM6328 Jonas Gorski
2012-06-12 8:23 ` [PATCH 1/8] MIPS: BCM63XX: move flash registration out of board_bcm963xx.c Jonas Gorski
2012-06-13 13:48 ` Ralf Baechle
2012-06-13 13:51 ` Florian Fainelli
2012-06-13 13:59 ` Ralf Baechle
2012-06-13 14:10 ` John Crispin
2012-06-13 15:35 ` Ralf Baechle
2012-06-16 11:03 ` Jonas Gorski
2012-06-12 8:23 ` [PATCH 2/8] MIPS: BCM63XX: add flash type detection Jonas Gorski
2012-06-12 8:23 ` [PATCH 3/8] MIPS: BCM63XX: use the Chip ID register for identifying the SoC Jonas Gorski
2012-06-12 8:23 ` [PATCH 4/8] MIPS: BCM63XX: add basic BCM6328 CPU support Jonas Gorski
2012-06-12 8:23 ` [PATCH 5/8] MIPS: BCM63XX: Move the PCI initialization into its own function Jonas Gorski
2012-06-12 8:23 ` [PATCH 6/8] MIPS: BCM63XX: Add PCIe Support for BCM6328 Jonas Gorski
2012-06-12 8:23 ` [PATCH 7/8] MIPS: expose PCIe drivers for MIPS Jonas Gorski
2012-06-12 8:23 ` [PATCH 8/8] MIPS: BCM63XX: add 96328avng reference board Jonas Gorski
2012-06-12 11:26 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525623.di3mH0BcIS@flexo \
--to=florian@openwrt.org \
--cc=cernekee@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox