* [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()
@ 2021-02-26 1:34 Yang Li
2021-02-26 14:23 ` Paul Cercueil
2021-03-03 9:08 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2021-02-26 1:34 UTC (permalink / raw)
To: paul; +Cc: linus.walleij, linux-mips, linux-gpio, linux-kernel, Yang Li
In one of the error paths of the for_each_child_of_node() loop in
ingenic_gpio_probe, add missing call to of_node_put().
Fix the following coccicheck warning:
./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2489.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
Changes in v2:
-add braces for if
drivers/pinctrl/pinctrl-ingenic.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c
index f274612..c8ecd01 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -2485,8 +2485,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
for_each_child_of_node(dev->of_node, node) {
if (of_match_node(ingenic_gpio_of_match, node)) {
err = ingenic_gpio_probe(jzpc, node);
- if (err)
+ if (err) {
+ of_node_put(node);
return err;
+ }
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()
2021-02-26 1:34 [PATCH v2] pinctrl: ingenic: add missing call to of_node_put() Yang Li
@ 2021-02-26 14:23 ` Paul Cercueil
2021-03-03 9:08 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2021-02-26 14:23 UTC (permalink / raw)
To: Yang Li; +Cc: linus.walleij, linux-mips, linux-gpio, linux-kernel
Hi,
Le ven. 26 févr. 2021 à 9:34, Yang Li <yang.lee@linux.alibaba.com> a
écrit :
> In one of the error paths of the for_each_child_of_node() loop in
> ingenic_gpio_probe, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return
> around
> line 2489.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
>
> Changes in v2:
> -add braces for if
>
> drivers/pinctrl/pinctrl-ingenic.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index f274612..c8ecd01 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -2485,8 +2485,10 @@ static int __init ingenic_pinctrl_probe(struct
> platform_device *pdev)
> for_each_child_of_node(dev->of_node, node) {
> if (of_match_node(ingenic_gpio_of_match, node)) {
> err = ingenic_gpio_probe(jzpc, node);
> - if (err)
> + if (err) {
> + of_node_put(node);
> return err;
> + }
> }
> }
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()
2021-02-26 1:34 [PATCH v2] pinctrl: ingenic: add missing call to of_node_put() Yang Li
2021-02-26 14:23 ` Paul Cercueil
@ 2021-03-03 9:08 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-03-03 9:08 UTC (permalink / raw)
To: Yang Li
Cc: Paul Cercueil, linux-mips, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org
On Fri, Feb 26, 2021 at 2:35 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
> In one of the error paths of the for_each_child_of_node() loop in
> ingenic_gpio_probe, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 2489.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Oops applied this rather than v1.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-03 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 1:34 [PATCH v2] pinctrl: ingenic: add missing call to of_node_put() Yang Li
2021-02-26 14:23 ` Paul Cercueil
2021-03-03 9:08 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox