Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

[Arnd Bergmann]

On Wed, Apr 6, 2022 at 6:15 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> The driver for LAN Media WAN interfaces spews build warnings on
> microblaze. The virt_to_bus() calls discard the volatile keyword.
> The right thing to do would be to migrate this driver to a modern
> DMA API but it seems unlikely anyone is actually using it.
> There had been no fixes or functional changes here since
> the git era begun.
>
> Let's remove this driver, there isn't much changing in the APIs,
> if users come forward we can apologize and revert.
>
> Link: https://lore.kernel.org/all/20220321144013.440d7fc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

[Thomas Bogendoerfer]

On Tue, Apr 05, 2022 at 09:15:48PM -0700, Jakub Kicinski wrote:
> The driver for LAN Media WAN interfaces spews build warnings on
> microblaze. The virt_to_bus() calls discard the volatile keyword.
> The right thing to do would be to migrate this driver to a modern
> DMA API but it seems unlikely anyone is actually using it.
> There had been no fixes or functional changes here since
> the git era begun.
> 
> Let's remove this driver, there isn't much changing in the APIs,
> if users come forward we can apologize and revert.
> 
> Link: https://lore.kernel.org/all/20220321144013.440d7fc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: Krzysztof Hałasa <khalasa@piap.pl>
> CC: Andrew Stanley-Jones <asj@cban.com>
> CC: Rob Braun <bbraun@vix.com>
> CC: Michael Graff <explorer@vix.com>,
> CC: Matt Thomas <matt@3am-software.com>
> CC: Arnd Bergmann <arnd@kernel.org>
> CC: tsbogend@alpha.franken.de # MIPS
> CC: linux-mips@vger.kernel.org
> CC: linus.walleij@linaro.org
> ---
>  arch/mips/configs/gpr_defconfig  |    1 -
>  arch/mips/configs/mtx1_defconfig |    1 -
>  drivers/net/wan/Kconfig          |   28 -
>  drivers/net/wan/Makefile         |    2 -
>  drivers/net/wan/lmc/Makefile     |   18 -
>  drivers/net/wan/lmc/lmc.h        |   33 -
>  drivers/net/wan/lmc/lmc_debug.c  |   65 -
>  drivers/net/wan/lmc/lmc_debug.h  |   52 -
>  drivers/net/wan/lmc/lmc_ioctl.h  |  255 ----
>  drivers/net/wan/lmc/lmc_main.c   | 2009 ------------------------------
>  drivers/net/wan/lmc/lmc_media.c  | 1206 ------------------
>  drivers/net/wan/lmc/lmc_proto.c  |  106 --
>  drivers/net/wan/lmc/lmc_proto.h  |   18 -
>  drivers/net/wan/lmc/lmc_var.h    |  468 -------
>  14 files changed, 4262 deletions(-)
>  delete mode 100644 drivers/net/wan/lmc/Makefile
>  delete mode 100644 drivers/net/wan/lmc/lmc.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_debug.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_debug.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_ioctl.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_main.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_media.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_proto.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_proto.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_var.h

Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

[Krzysztof Hałasa]

Jakub Kicinski <kuba@kernel.org> writes:

> The driver for LAN Media WAN interfaces spews build warnings on
> microblaze. The virt_to_bus() calls discard the volatile keyword.
> The right thing to do would be to migrate this driver to a modern
> DMA API but it seems unlikely anyone is actually using it.
> There had been no fixes or functional changes here since
> the git era begun.
>
> Let's remove this driver, there isn't much changing in the APIs,
> if users come forward we can apologize and revert.

I wouldn't hold my breath, though :-)

Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa

Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue,  5 Apr 2022 21:15:48 -0700 you wrote:
> The driver for LAN Media WAN interfaces spews build warnings on
> microblaze. The virt_to_bus() calls discard the volatile keyword.
> The right thing to do would be to migrate this driver to a modern
> DMA API but it seems unlikely anyone is actually using it.
> There had been no fixes or functional changes here since
> the git era begun.
> 
> [...]

Here is the summary with links:
  - [net-next] net: wan: remove the lanmedia (lmc) driver
    https://git.kernel.org/netdev/net-next/c/a5b116a0fa90

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html