From: Ulf Carlsson <ulfc@bun.falkenberg.se>
To: Alex deVries <adevries@engsoc.carleton.ca>
Cc: Linux SGI <linux@cthulhu.engr.sgi.com>
Subject: Re: HAL2 support.
Date: Thu, 28 Jan 1999 19:50:21 +0100 [thread overview]
Message-ID: <19990128195021.A897@bun.falkenberg.se> (raw)
In-Reply-To: <Pine.LNX.3.96.990125122018.21345K-100000@lager.engsoc.carleton.ca>; from Alex deVries on Mon, Jan 25, 1999 at 01:12:55PM -0500
> First, many thanks for the files.
>
> Do you mind if I cvs upload them to the SGI kernel mailing list?
CVS upload them to the mailing list, I don't get your point here. I have CVS
access so I may upload them if I want to, and I can post it to the mailing list
if you want me to. But it feels like too much people would laugh at me if I
posted it at the moment.. I'll atleast get it through the compiler once again.
> Do you mind if we hold this discussion on the SGI list once I do that?
Sure, I actually forgot to group reply, that's why this discussion isn't
(wasn't) on the list :-)
> Next, I was hoping you could explain this bit of code to me, I don't quite
> see how it's right from the docs. I'm looking at page 13 of the HAL2
> docs.
Does something else bother you than the incorrect type? I can't see anything
else being wrong here.
[snip]
> typedef volatile unsigned long hpcreg;
How stupid! I thought I had checked that it was unsigned short.. ;)
My spacing depends on that..
> Next, your spacing isn't quite right I don't think. I think it needs to
> be:
>
> typedef volatile __u16 hal_reg;
>
> struct hal2_ctrl_regs {
> hal_reg _unused0[8];
> hal_reg isr; /* 0x10 Status Register */
> hal_reg _unused1[7];
> hal_reg rev; /* 0x20 Revision Register */
> hal_reg _unused2[7];
> hal_reg iar; /* 0x30 Indirect Address Register */
> hal_reg _unused3[7];
> hal_reg idr0; /* 0x40 Indirect Data Register 0 */
> hal_reg _unused4[7];
> hal_reg idr1; /* 0x50 Indirect Data Register 1 */
> hal_reg _unused5[7];
> hal_reg idr2; /* 0x60 Indirect Data Register 2 */
> hal_reg _unused6[7];
> hal_reg idr3; /* 0x70 Indirect Data Register 3 */
> } *h2_ctrl = (hal2_ctrl_regs *) H2_CTRL_PIO;
And this line should actually be:
} *h2_ctrl = (hal2_ctrl_regs *) KSEG1ADDR(H2_CTRL_PIO);
> Does that make sense, or otherwise, what was your thought on this?
It probably does, I have found two bugs so far.
- Ulf
next parent reply other threads:[~1999-01-25 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19990128004527.A1266@bun.falkenberg.se>
[not found] ` <Pine.LNX.3.96.990125122018.21345K-100000@lager.engsoc.carleton.ca>
1999-01-28 18:50 ` Ulf Carlsson [this message]
1999-01-25 19:27 ` HAL2 support Alex deVries
1999-01-28 20:32 ` Ulf Carlsson
1999-01-24 21:01 Alex deVries
1999-01-25 4:06 ` Dave Olson
1999-01-25 4:06 ` Dave Olson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990128195021.A897@bun.falkenberg.se \
--to=ulfc@bun.falkenberg.se \
--cc=adevries@engsoc.carleton.ca \
--cc=linux@cthulhu.engr.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox