Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@uni-koblenz.de>
To: Mark Mitchell <mark@codesourcery.com>
Cc: ralf@gnu.org, binutils@sourceware.cygnus.com,
	thockin@cobaltnet.com, linux@cthulhu.engr.sgi.com,
	linux-mips@fnet.fr, linux-mips@vger.rutgers.edu
Subject: Re: MIPS/ELF linker
Date: Sun, 1 Aug 1999 01:22:03 +0200	[thread overview]
Message-ID: <19990801012203.U12249@uni-koblenz.de> (raw)
In-Reply-To: <19990731152842N.mitchell@codesourcery.com>; from Mark Mitchell on Sat, Jul 31, 1999 at 03:28:42PM -0700

On Sat, Jul 31, 1999 at 03:28:42PM -0700, Mark Mitchell wrote:

> Thanks for trying the MIPS backend out.  I'm eager to shake out the
> bugs.  It seems pretty solid on IRIX6, now, but I'm sure there are
> issues remaining on other platforms.
> 
>   +  /* Assume no jalx is required  */
>   +  *require_jalxp = false;
>   +
> 
> REQUIRE_JALXP is set unconditionally a few lines down.  Why doesn't
> that do the trick?  The caller should not be looking at the value of
> require_jalx unless calculate_relocation returns a successful error
> code.

So the caller _bfd_mips_elf_relocate_section does not behave appropriately
when mips_elf_calculate_relocation returns bfd_reloc_undefined.  Search
for bfd_reloc_undefined in mips_elf_calculate_relocation; it's being
returned before an actual value gets assigned to *require_jalxp.

>   /usr/bin/mips-linux-ld: not enough GOT space for local GOT entries
> 
> Probably some relocation is requiring a local GOT entry, but we're not
> allocating it.  Look for this code in check_relocs:
> 
>       if (!h && (r_type == R_MIPS_CALL_LO16
> 		 || r_type == R_MIPS_GOT_LO16
> 		 || r_type == R_MIPS_GOT_DISP))
> 	{
> 	  /* We may need a local GOT entry for this relocation.  We
> 	     don't count R_MIPS_HI16 or R_MIPS_GOT16 relocations
> 	     because they are always followed by a R_MIPS_LO16
> 	     relocation for the value.  We don't R_MIPS_GOT_PAGE
> 	     because we can estimate the maximum number of pages
> 	     needed by looking at the size of the segment.
> 
> 	     This estimation is very conservative since we can merge
> 	     duplicate entries in the GOT.  In order to be less
> 	     conservative, we could actually build the GOT here,
> 	     rather than in relocate_section.  */
> 	  g->local_gotno++;
> 	  sgot->_raw_size += MIPS_ELF_GOT_SIZE (dynobj);
> 	}
> 
> Probably this code is not firing in some case where it should be
> firing.  Therefore, we're not adding enough GOT space.  That might
> help track down the bug.  
> 
> If not, feel free to send me the files on your link-line in a giant
> tar-ball, together with how your configuring binutils, and I'll try to
> duplicate and fix your problem.

I'll send you a non-giant tarball of 73kb which will demonstrate the
problem.  Just run the Makefile in the archive.  The linker has been
configured for the target mips-linux which is a standard MIPS/ELF target.

  Ralf

       reply	other threads:[~1999-07-31 23:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <19990731233150.Q12249@uni-koblenz.de>
     [not found] ` <19990731152842N.mitchell@codesourcery.com>
1999-07-31 23:22   ` Ralf Baechle [this message]
     [not found]     ` <19990731164237C.mitchell@codesourcery.com>
1999-07-31 23:44       ` MIPS/ELF linker Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19990801012203.U12249@uni-koblenz.de \
    --to=ralf@uni-koblenz.de \
    --cc=binutils@sourceware.cygnus.com \
    --cc=linux-mips@fnet.fr \
    --cc=linux-mips@vger.rutgers.edu \
    --cc=linux@cthulhu.engr.sgi.com \
    --cc=mark@codesourcery.com \
    --cc=ralf@gnu.org \
    --cc=thockin@cobaltnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox