From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Yuan Tan <tanyuan@tinylab.org>,
tsbogend@alpha.franken.de, 42.hyeyoo@gmail.com
Cc: linux-mips@vger.kernel.org, christophe.leroy@csgroup.eu,
linux-kernel@vger.kernel.org, falcon@tinylab.org, w@1wt.eu,
linux@weissschuh.net
Subject: Re: [PATCH v3 3/3] MIPS: Simplify malta_defconfig
Date: Fri, 15 Sep 2023 15:35:06 +0200 [thread overview]
Message-ID: <19e21e8c-95ea-362d-1ead-9369c211dba2@linaro.org> (raw)
In-Reply-To: <4d946232ffdd8891a32d4a9f17dbca10a4aa465d.1694680448.git.tanyuan@tinylab.org>
On 14/9/23 10:44, Yuan Tan wrote:
> Simplify malta_defconfig with POWER_RESET dependences.
>
> Regenerate malta_defconfig with 'make savedefconfig'.
>
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Yuan Tan <tanyuan@tinylab.org>
> ---
> arch/mips/configs/malta_defconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
> index 7ae07d57b79a..99049e993192 100644
> --- a/arch/mips/configs/malta_defconfig
> +++ b/arch/mips/configs/malta_defconfig
> @@ -192,7 +192,6 @@ CONFIG_CFG80211=m
> CONFIG_MAC80211=m
> CONFIG_MAC80211_MESH=y
> CONFIG_RFKILL=m
> -CONFIG_PCI=y
> CONFIG_DEVTMPFS=y
> CONFIG_CONNECTOR=m
> CONFIG_MTD=y
> @@ -284,7 +283,6 @@ CONFIG_MOUSE_PS2_ELANTECH=y
> CONFIG_SERIAL_8250=y
> CONFIG_SERIAL_8250_CONSOLE=y
> CONFIG_POWER_RESET=y
> -CONFIG_POWER_RESET_PIIX4_POWEROFF=y
> CONFIG_POWER_RESET_SYSCON=y
> # CONFIG_HWMON is not set
> CONFIG_FB=y
IMHO this should be squashed with the previous patch,
to keep it "atomic", easing reverts or cherry-picks
during backports.
next prev parent reply other threads:[~2023-09-15 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 8:43 [PATCH v3 0/3] Add dependencies of POWER_RESET for MIPS Malta Yuan Tan
2023-09-14 8:43 ` [PATCH v3 1/3] MIPS: Cleanup malta_defconfig Yuan Tan
2023-09-15 13:32 ` Philippe Mathieu-Daudé
2023-09-14 8:43 ` [PATCH v3 2/3] Kconfig: add dependencies of POWER_RESET for mips malta Yuan Tan
2023-09-14 8:44 ` [PATCH v3 3/3] MIPS: Simplify malta_defconfig Yuan Tan
2023-09-15 13:35 ` Philippe Mathieu-Daudé [this message]
2023-09-15 18:03 ` Yuan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e21e8c-95ea-362d-1ead-9369c211dba2@linaro.org \
--to=philmd@linaro.org \
--cc=42.hyeyoo@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=tanyuan@tinylab.org \
--cc=tsbogend@alpha.franken.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).