From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, tsbogend@alpha.franken.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: mfd: Add Realtek switch
Date: Tue, 24 Sep 2024 10:51:24 +0200 [thread overview]
Message-ID: <1c19de70-abab-469b-afd0-f585cc807e04@kernel.org> (raw)
In-Reply-To: <jdqmrbjngrcmxtow2khhplvhhv6oh4msts4lggogfbgjj7fyfn@dve6dxeijywz>
On 24/09/2024 10:39, Krzysztof Kozlowski wrote:
> On Tue, Sep 24, 2024 at 10:57:17AM +1200, Chris Packham wrote:
>> Add device tree schema for the Realtek switch. Currently the only
>> supported feature is the syscon-reboot which is needed to be able to
>> reboot the board.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Unreviewed - it is incomplete!
No, we said multiple times, you must send complete binding. Sending
pieces for review does not give us full picture and hides parts of the
controversial decisions. If you want to go this way, next time you will
get NAK when adding i2c@0-7 to parent binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-24 8:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 22:57 [PATCH v4 0/3] mips: realtek: Add reboot support Chris Packham
2024-09-23 22:57 ` [PATCH v4 1/3] dt-bindings: mfd: Add Realtek switch Chris Packham
2024-09-24 8:39 ` Krzysztof Kozlowski
2024-09-24 8:51 ` Krzysztof Kozlowski [this message]
2024-09-24 20:56 ` Chris Packham
2024-09-24 22:16 ` [RFC PATCH v4.5] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals Chris Packham
2024-09-24 23:21 ` Rob Herring (Arm)
2024-09-25 7:25 ` Krzysztof Kozlowski
2024-09-25 8:08 ` [PATCH v4 1/3] dt-bindings: mfd: Add Realtek switch Krzysztof Kozlowski
2024-09-23 22:57 ` [PATCH v4 2/3] mips: dts: realtek: Add syscon-reboot node Chris Packham
2024-09-24 8:40 ` Krzysztof Kozlowski
2024-09-23 22:57 ` [PATCH v4 3/3] dt-bindings: mfd: Add more RTL9300 variants Chris Packham
2024-09-24 8:40 ` Krzysztof Kozlowski
2024-09-24 20:59 ` Chris Packham
2024-09-25 7:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c19de70-abab-469b-afd0-f585cc807e04@kernel.org \
--to=krzk@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).