From: Ralf Baechle <ralf@oss.sgi.com>
To: Carsten Langgaard <carstenl@mips.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: Bug in get_insn_opcode.
Date: Sat, 3 Mar 2001 08:21:15 +0100 [thread overview]
Message-ID: <20010303082115.B5750@bacchus.dhis.org> (raw)
In-Reply-To: <3A9FD0D0.887E372F@mips.com>; from carstenl@mips.com on Fri, Mar 02, 2001 at 05:56:48PM +0100
On Fri, Mar 02, 2001 at 05:56:48PM +0100, Carsten Langgaard wrote:
> Date: Fri, 02 Mar 2001 17:56:48 +0100
> From: Carsten Langgaard <carstenl@mips.com>
> To: linux-mips@oss.sgi.com
> Subject: Bug in get_insn_opcode.
>
> There is a bug in the function get_insn_opcode in traps.c
>
> As 'epc' is an int pointer here, it should only be increased by 1 (4
> byte) and not by 4 (4*4 = 16 bytes).
> See the patch below.
> Index: arch/mips/kernel/traps.c
> ===================================================================
> RCS file: /home/repository/sw/linux-2.4.0/arch/mips/kernel/traps.c,v
> retrieving revision 1.10
> diff -u -r1.10 traps.c
> --- traps.c 2001/02/28 13:46:43 1.10
> +++ traps.c 2001/03/02 16:50:27
Patch will behave (un-)funny on a cvs diff generated patch like this which
lacks full pathnames in the --- and +++ lines. Patches for this
behaviour are available on ftp.cyclic.com (so it still exists ...) or in
more recent cvs rpms.
Applied anyway, of course.
Ralf
next prev parent reply other threads:[~2001-03-03 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-02 16:56 Bug in get_insn_opcode Carsten Langgaard
2001-03-02 18:34 ` Jun Sun
2001-03-03 7:21 ` Ralf Baechle [this message]
2001-03-03 15:15 ` Geert Uytterhoeven
2001-03-04 19:48 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010303082115.B5750@bacchus.dhis.org \
--to=ralf@oss.sgi.com \
--cc=carstenl@mips.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox