From: Ralf Baechle <ralf@oss.sgi.com>
To: Keith Owens <kaos@melbourne.sgi.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: 2.4.4-pre5 drivers/sgi/char/Makefile
Date: Tue, 24 Apr 2001 11:58:50 -0300 [thread overview]
Message-ID: <20010424115850.C5379@bacchus.dhis.org> (raw)
In-Reply-To: <12767.988066712@ocs3.ocs-net>; from kaos@melbourne.sgi.com on Tue, Apr 24, 2001 at 08:58:32AM +1000
On Tue, Apr 24, 2001 at 08:58:32AM +1000, Keith Owens wrote:
> I am trying to make sense of drivers/sgi/char/Makefile in 2.4.4-pre5.
>
> export-objs := newport.o shmiq.o sgicons.o usema.o
> obj-y := newport.o shmiq.o sgicons.o usema.o streamable.o
>
> obj-$(CONFIG_SGI_SERIAL) += sgiserial.o
> obj-$(CONFIG_SGI_DS1286) += ds1286.o
> obj-$(CONFIG_SGI_NEWPORT_GFX) += graphics.o rrm.o
>
> None of newport.o shmiq.o sgicons.o usema.o export any symbols so why
> are they defined as export-objs? The only object that does export
> symbols is graphics_syms.c and no Makefile refers to that source, it
> appears to be dead.
>
> I recommend removing all export-objs from drivers/sgi/char/Makefile and
> deleting drivers/sgi/char/graphics_syms.c.
The real fix is one of many patches pending to be merged with Linus ...
Ralf
prev parent reply other threads:[~2001-04-24 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-23 22:58 2.4.4-pre5 drivers/sgi/char/Makefile Keith Owens
2001-04-24 14:58 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010424115850.C5379@bacchus.dhis.org \
--to=ralf@oss.sgi.com \
--cc=kaos@melbourne.sgi.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox