From: "H . J . Lu" <hjl@lucon.org>
To: James Simmons <jsimmons@transvirtual.com>
Cc: linux-mips@oss.sgi.com
Subject: Re: PATCH: Fix offset of mmap
Date: Fri, 14 Sep 2001 10:15:49 -0700 [thread overview]
Message-ID: <20010914101549.A16156@lucon.org> (raw)
In-Reply-To: <Pine.LNX.4.10.10109141009260.20461-100000@transvirtual.com>; from jsimmons@transvirtual.com on Fri, Sep 14, 2001 at 10:10:58AM -0700
On Fri, Sep 14, 2001 at 10:10:58AM -0700, James Simmons wrote:
>
> > We should check if offset of mmap is on the page boundary.
>
> I believe this would break certain pieces of hardware. For example the
> mq200 framebuffer in the sigmarion is not paged aligned. You have to
> supply a offset to make it work.
How do you mmap a memory whose offset is not page aligned? The code
here is
return do_mmap2(addr, len, prot, flags, fd, offset >> PAGE_SHIFT);
^^^^^^^^^^^^^^^^^^^^
It is up to the user code to make sure everything is ok.
H.J.
next prev parent reply other threads:[~2001-09-14 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-14 17:07 PATCH: Fix offset of mmap H . J . Lu
2001-09-14 17:10 ` James Simmons
2001-09-14 17:15 ` H . J . Lu [this message]
2001-09-14 17:27 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010914101549.A16156@lucon.org \
--to=hjl@lucon.org \
--cc=jsimmons@transvirtual.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).