From: Ralf Baechle <ralf@oss.sgi.com>
To: Jun Sun <jsun@mvista.com>
Cc: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>,
linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: [patch] linux 2.4.9: Bad code in xchg_u32()
Date: Wed, 17 Oct 2001 02:57:21 +0200 [thread overview]
Message-ID: <20011017025721.A15129@dea.linux-mips.net> (raw)
In-Reply-To: <3BCCB979.FFBFE85B@mvista.com>; from jsun@mvista.com on Tue, Oct 16, 2001 at 03:49:29PM -0700
On Tue, Oct 16, 2001 at 03:49:29PM -0700, Jun Sun wrote:
> > > Unfortunately, gcc 2.95.3 doesn't want to accept a "=R" output constraint
> > > here so I had to use "=m". It looks like a bug in gcc. Until it is fixed
> > > the "R" input constraint here is sufficient for gcc to know it has m
> > > already available in one of registers. I added ".set nomacro" to make
> > > sure the second ll fits in the BDS as well.
> >
> > I've added the "memory" clobber back; xchg() is expected to imply a memory
> > barrier.
> >
> > "R" indeed seems to be fishy; I can't compile the kernel if I remove
> > the volatile from the first argument of xchg_u32(). I'd feel safer if
> > we could use "m" until we can be sure "R" works fine.
>
> Is there any reason to think "R" *should* be better than "m"?
Single instruction loads that is no macros.
Ralf
next prev parent reply other threads:[~2001-10-17 1:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-16 17:06 [patch] linux 2.4.9: Bad code in xchg_u32() Maciej W. Rozycki
2001-10-16 22:29 ` Ralf Baechle
2001-10-16 22:49 ` Jun Sun
2001-10-17 0:57 ` Ralf Baechle [this message]
2001-10-17 11:07 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011017025721.A15129@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=jsun@mvista.com \
--cc=linux-mips@fnet.fr \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox