From: "Bradley D. LaRonde" <brad@ltc.com>
To: ralf@oss.sgi.com
Cc: linux-mips@oss.sgi.com
Subject: PATCH: require dev_id for shared irq
Date: Sun, 28 Oct 2001 15:47:46 -0500 [thread overview]
Message-ID: <20011028154746.A10762@dev1.ltc.com> (raw)
2001-10-28 Bradley D. LaRonde <brad@ltc.com>
- Require a dev_id for shared interrupts.
--- arch/mips/kernel/irq.c 2001/10/12 01:41:17 1.36
+++ arch/mips/kernel/irq.c 2001/10/28 20:43:19
@@ -350,18 +350,12 @@
int retval;
struct irqaction * action;
-#if 1
/*
- * Sanity-check: shared interrupts should REALLY pass in
- * a real dev-ID, otherwise we'll have trouble later trying
- * to figure out which interrupt is which (messes up the
- * interrupt freeing logic etc).
+ * Shared interrupts require a dev_id, otherwise we can't
+ * later figure out which interrupt to free.
*/
- if (irqflags & SA_SHIRQ) {
- if (!dev_id)
- printk("Bad boy: %s (at 0x%x) called us without a dev_id!\n", devname, (&irq)[-1]);
- }
-#endif
+ if ((irqflags & SA_SHIRQ) && !dev_id)
+ return -EINVAL;
if (irq >= NR_IRQS)
return -EINVAL;
reply other threads:[~2001-10-28 20:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011028154746.A10762@dev1.ltc.com \
--to=brad@ltc.com \
--cc=linux-mips@oss.sgi.com \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox