Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@oss.sgi.com>
To: Guido Guenther <agx@sigxcpu.org>
Cc: linux-mips@oss.sgi.com
Subject: Re: arcboot patches
Date: Tue, 6 Nov 2001 11:35:18 -0800	[thread overview]
Message-ID: <20011106113517.F1524@dea.linux-mips.net> (raw)
In-Reply-To: <20011104233218.A15847@bogon.ms20.nix>; from agx@sigxcpu.org on Sun, Nov 04, 2001 at 11:32:19PM +0100

On Sun, Nov 04, 2001 at 11:32:19PM +0100, Guido Guenther wrote:

>  typedef struct {
> +#ifdef __MIPSEL__
>  	ULONG LowPart;
> +	*LONG HighPart;
> +#else /* !(__MIPSEL__) */
>  	LONG HighPart;
> +	ULONG LowPart;
> +#endif
>  } LARGEINTEGER;

Why not simply defining LARGEINTEGER as long long?

> Index: arclib/spb.h
> ===================================================================
> RCS file: /cvs/arcboot/arclib/spb.h,v
> retrieving revision 1.2
> diff -u -u -r1.2 spb.h
> --- arclib/spb.h	2001/03/20 02:55:56	1.2
> +++ arclib/spb.h	2001/11/04 22:06:28
> @@ -90,7 +90,7 @@
>  	ADAPTER Adapters[1];
>  } SPB;
>  
> -#define SystemParameterBlock	((SPB *) 0x1000)
> +#define SystemParameterBlock	((SPB *) 0xA0001000UL) 

That should be 0x80001000UL I think.

> -EXT2LIB = /usr/lib/libext2fs.a
> +#EXT2LIB = /usr/lib/libext2fs.a
> +EXT2LIB = ../../e2fslib/e2fsprogs-1.25/lib/libext2fs.a

That needs to be a non-pic library which nobody has installed on his
system so I suggest we just put a copy of libext2fs into the arcboot
sources.  That would alos make arcboot selfcontained and eleminate
build problems.

  Ralf

  reply	other threads:[~2001-11-06 19:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-04 22:32 arcboot patches Guido Guenther
2001-11-06 19:35 ` Ralf Baechle [this message]
2001-11-07 12:29   ` Guido Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011106113517.F1524@dea.linux-mips.net \
    --to=ralf@oss.sgi.com \
    --cc=agx@sigxcpu.org \
    --cc=linux-mips@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox