From: Ralf Baechle <ralf@oss.sgi.com>
To: ldavies@agile.tv
Cc: linux-mips@oss.sgi.com
Subject: Re: [PATCH] mips_atomic_set fixups (with LLSC)
Date: Thu, 6 Dec 2001 15:17:59 -0200 [thread overview]
Message-ID: <20011206151759.H3325@dea.linux-mips.net> (raw)
In-Reply-To: <3C0F059A.30709@agile.tv>; from ldavies@agile.tv on Thu, Dec 06, 2001 at 03:43:54PM +1000
On Thu, Dec 06, 2001 at 03:43:54PM +1000, Liam Davies wrote:
> The kernel can be caused to crash when making the following syscall
> sysmips(MIPS_ATOMIC_SET, [unaligned addr], value, 0);
>
> The latest mips_atomic_set does not use the fixups that are defined
> for the ll/sc instructions.
>
> If an unaligned address is passed in we take the exception and
> unaligned.c:emulate_load_store_insn ignores the fixups for the
> ll/sc and sends a SIGBUS instead, thus causing the kernel to die.
An unaligned ll/sc instruction in the kernel is a bug in itself as such
it's not unaligned.c that is to blame. As such I'm going to checkin
a patch that is close but not identical to your patch.
Blame me for this bug, I *knew* and forgot about it ...
Ralf
prev parent reply other threads:[~2001-12-06 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-06 5:43 [PATCH] mips_atomic_set fixups (with LLSC) Liam Davies
2001-12-06 17:17 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011206151759.H3325@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=ldavies@agile.tv \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox