From: Jim Paris <jim@jtan.com>
To: Justin Carlson <justinca@ri.cmu.edu>
Cc: linux-mips@oss.sgi.com
Subject: Re: PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers
Date: Fri, 7 Dec 2001 14:43:43 -0500 [thread overview]
Message-ID: <20011207144343.A4417@neurosis.mit.edu> (raw)
In-Reply-To: <1007753789.1680.1.camel@GLOVEBOX.AHS.RI.CMU.EDU>; from justinca@ri.cmu.edu on Fri, Dec 07, 2001 at 02:36:28PM -0500
> Maybe I missed this, but is there any reason for the patch, other then
> a personal preference of how to do macros that look like functions?
> I've seen gcc do strange non-optimal things with functions declared
> inlines, but I've never seen it generate bad code WRT to do{}while(0)
> constructs.
>
> Unless I'm missing something, this patch looks like a solution in search
> of a problem...
In the case of set_io_port_base, I see no real reason. But for the
out[b,w,l] functions, having the do/while can prevent constructs that
might otherwise make sense, like
for(i=0;i<10;i++,outb(i,port)) {
...
}
Okay, so it's a bad example, but.. :) Maybe Brad has a better one.
-jim
next prev parent reply other threads:[~2001-12-07 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-07 17:14 PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers Bradley D. LaRonde
2001-12-07 17:30 ` Geert Uytterhoeven
2001-12-07 17:38 ` Daniel Jacobowitz
2001-12-07 18:04 ` Jim Paris
2001-12-07 18:06 ` Ralf Baechle
2001-12-07 18:15 ` Jim Paris
2001-12-07 19:36 ` Justin Carlson
2001-12-07 19:43 ` Jim Paris [this message]
2001-12-07 20:23 ` Bradley D. LaRonde
2001-12-07 20:23 ` Bradley D. LaRonde
2001-12-07 20:44 ` Justin Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011207144343.A4417@neurosis.mit.edu \
--to=jim@jtan.com \
--cc=justinca@ri.cmu.edu \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox