From: Geoffrey Espin <espin@idiom.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-mips <linux-mips@oss.sgi.com>
Subject: Re: No bzImage target for MIPS
Date: Thu, 13 Dec 2001 20:12:10 -0800 [thread overview]
Message-ID: <20011213201210.A86040@idiom.com> (raw)
In-Reply-To: <1901.1008301881@kao2.melbourne.sgi.com>; from Keith Owens on Fri, Dec 14, 2001 at 02:51:21PM +1100
Keith,
On Fri, Dec 14, 2001 at 02:51:21PM +1100, Keith Owens wrote:
> >#include "../../../fs/jffs2/zlib.c" /**/
> >#include "../../../lib/ctype.c"
> I am phasing out the practice of ../ in kernel include paths. It is
> much better to do
> #include "zlib.c"
> #include "ctype.c"
> and the Makefile adds -I$(TOPDIR)/fs/jffs2 -I$(TOPDIR)/lib. Then when
I'll check around the tree. Doesn't matter to me. Both have crappy
implications. I hate it when -I's pile up... and you don't know which
directory takes precedence (esp. if there are duplicate names).
> >TOPDIR = ../../..
> TOPDIR := $(shell cd ../../..; /bin/pwd)
> is better, it returns an absolute path instead of a relative one.
Hmmm, okay. I probably shouldn't even have this macro.
I had hacked things earlier so I didn't have to run 'make' from linux/.
Thanks for the quick feedback, mate!
[I'll spare someone pointing out that I should have tried to use
linux/lib/vsprintf.c. Missed it! What a newbie.]
Geoff
--
Geoffrey Espin
espin@idiom.com
next prev parent reply other threads:[~2001-12-14 5:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-14 0:47 No bzImage target for MIPS Krishna Kondaka
2001-12-14 1:10 ` Pete Popov
2001-12-14 3:28 ` Geoffrey Espin
2001-12-14 3:51 ` Keith Owens
2001-12-14 4:12 ` Geoffrey Espin [this message]
2001-12-14 18:05 ` Pete Popov
2001-12-14 18:52 ` Geoffrey Espin
2001-12-14 19:11 ` Pete Popov
2001-12-15 8:31 ` Karsten Merker
2001-12-15 9:14 ` Keith Owens
2001-12-15 12:46 ` Florian Lohoff
2001-12-17 20:32 ` Ralf Baechle
2001-12-17 13:12 ` Maciej W. Rozycki
2001-12-15 12:42 ` Florian Lohoff
-- strict thread matches above, loose matches on Subject: below --
2001-12-14 0:55 Marc Karasek
2001-12-14 22:59 Marc Karasek
2001-12-14 23:42 ` Pete Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011213201210.A86040@idiom.com \
--to=espin@idiom.com \
--cc=kaos@ocs.com.au \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox